Add a Build::IsRelease and Build::IsNightly (#5777)

And trigger the title var version in standalone using it
surge-synthesizer · Jan 17, 2022 · eed15b6 · eed15b6
1 parent 89e645f
commit eed15b6
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 3 deletions.
diff --git a/cmake/versiontools.cmake b/cmake/versiontools.cmake
@@ -68,6 +68,7 @@ else ()
     set(lpipeline "local")
 endif ()
 
+set(isrelease 0)
 if (${GIT_BRANCH} STREQUAL "main")
     if (${AZURE_PIPELINE})
         set(lverpatch "nightly")
@@ -91,6 +92,7 @@ else ()
         endif ()
         set(lverpatch "stable-${lverrel}")
         set(fverpatch "${lverrel}")
+        set(isrelease 1)
     else ()
         set(lverpatch ${GIT_BRANCH})
         set(fverpatch ${lverpatch})
@@ -105,6 +107,7 @@ set(SURGE_RELEASE_VERSION "${lverpatch}")
 set(SURGE_RELEASE_NUMBER "${lverrel}")
 set(SURGE_BUILD_HASH "${GIT_COMMIT_HASH}")
 set(SURGE_BUILD_LOCATION "${lpipeline}")
+set(SURGE_BUILD_IS_RELEASE "${isrelease}")
 
 string(TIMESTAMP SURGE_BUILD_DATE "%Y-%m-%d")
 string(TIMESTAMP SURGE_BUILD_YEAR "%Y")

diff --git a/src/common/version.cpp.in b/src/common/version.cpp.in
@@ -5,6 +5,7 @@
 */
 #include "version.h"
 
+// clang-format off
 namespace Surge
 {
    const char* Build::MajorVersionStr = "@SURGE_MAJOR_VERSION@";
@@ -15,7 +16,10 @@ namespace Surge
 
    const char* Build::ReleaseNumberStr = "@SURGE_RELEASE_NUMBER@";
    const char* Build::ReleaseStr = "@SURGE_RELEASE_VERSION@";
-
+
+   const bool Build::IsRelease = @SURGE_BUILD_IS_RELEASE@;
+   const bool Build::IsNightly = ! Build::IsRelease;
+
    const char* Build::BuildNumberStr = "@SURGE_BUILD_HASH@"; // Build number to be sure that each result could identified.
 
    const char* Build::FullVersionStr = "@SURGE_FULL_VERSION@";
@@ -34,4 +38,4 @@ namespace Surge
 
    const char* Build::CMAKE_INSTALL_PREFIX = "@CMAKE_INSTALL_PREFIX@";
 }
-
+// clang-format on
diff --git a/src/common/version.h b/src/common/version.h
@@ -14,6 +14,9 @@ struct Build
     static const char *ReleaseNumberStr;
     static const char *ReleaseStr;
 
+    static const bool IsRelease; // vs nightly
+    static const bool IsNightly;
+
     static const char *GitHash;
     static const char *GitBranch;
 

diff --git a/src/surge-xt/gui/SurgeJUCELookAndFeel.cpp b/src/surge-xt/gui/SurgeJUCELookAndFeel.cpp
@@ -173,6 +173,9 @@ void SurgeJUCELookAndFeel::drawDocumentWindowTitleBar(DocumentWindow &window, Gr
     surgeVersion += " DEBUG";
 #endif
 
+    if (Surge::Build::IsRelease)
+        surgeVersion = "";
+
     if (wt != "Surge XT")
     {
         surgeLabel = "Surge XT -";
@@ -187,7 +190,7 @@ void SurgeJUCELookAndFeel::drawDocumentWindowTitleBar(DocumentWindow &window, Gr
 
     // Surge icon is 12 x 14 so draw that in the center
     auto titleCenter = w / 2;
-    auto textMargin = 5;
+    auto textMargin = Surge::Build::IsRelease ? 0 : 5;
     auto titleTextWidth = sw + vw + textMargin;
 
     if (ic)