Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove string-prototype-matchall #60

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove string-prototype-matchall #60

wants to merge 1 commit into from

Conversation

donmccurdy
Copy link

@donmccurdy donmccurdy commented Jun 23, 2024 •
edited
Loading

Removes string-prototype-matchall. Support for String.prototype.matchAll landed in Node.js v12, and Node.js v16 reached EOL in September 2023, so I agree with the poster of #58 that the need for this shim is now gone. While reviewing my own package dependencies, this was a big source. Thank you!

@donmccurdy donmccurdy requested a review from surma as a code owner June 23, 2024 22:39
@donmccurdy donmccurdy mentioned this pull request Jun 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surma surma Awaiting requested review from surma surma is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove bloated and no longer required string.prototype.matchall dependency
1 participant
@donmccurdy