resolve #6499 shifted helper text

surveyjs · Feb 13, 2025 · 748d70e · 748d70e
1 parent 2e8698e
commit 748d70e
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 2 deletions.
diff --git a/packages/survey-creator-core/src/property-grid-theme/property-grid.scss b/packages/survey-creator-core/src/property-grid-theme/property-grid.scss
@@ -116,7 +116,7 @@
   // padding-left: 0;
 
   .spg-help-action {
-    flex-grow: 1;
+    margin-inline-end: auto;
 
     .spg-action-button--icon {
       padding: var(--ctr-actionbar-button-padding-top-small-icon, var(--sjs-spacing-x05))

diff --git a/packages/survey-creator-core/src/property-grid/index.ts b/packages/survey-creator-core/src/property-grid/index.ts
@@ -448,6 +448,7 @@ export class PropertyGridTitleActionsCreator {
       iconSize: "auto",
       css: "spg-help-action",
       showTitle: false,
+      disableHide: true,
       action: () => {
         question.descriptionLocation =
           question.descriptionLocation != "hidden" ? "hidden" : "underTitle";

diff --git a/visualRegressionTests-V2/tests/designer/etalons/helper-action.png b/visualRegressionTests-V2/tests/designer/etalons/helper-action.png
diff --git a/visualRegressionTests/tests/designer/pg-editors.ts b/visualRegressionTests/tests/designer/pg-editors.ts
@@ -864,7 +864,7 @@ test("popup overlay in property grid", async (t) => {
     await takeElementScreenshot("pg-overlay-popup.png", getVisibleElement(".sv-popup .sv-popup__container"), t, comparer);
   });
 });
-fixture`${title}`.page`${url}`.beforeEach(async (t) => { });
+
 test("Check creator theme settings", async (t) => {
   await wrapVisualTest(t, async (t, comparer) => {
     await t.resizeWindow(1920, 1080);
@@ -877,3 +877,18 @@ test("Check creator theme settings", async (t) => {
     await takeElementScreenshot("creator-theme-settings.png", getVisibleElement(".spg-body"), t, comparer);
   });
 });
+
+test("Helper action not hidden", async (t) => {
+  await wrapVisualTest(t, async (t, comparer) => {
+    await t.resizeWindow(1240, 870);
+    const westResizer = Selector(".svc-resizer-west");
+    const questionHeader = getPropertyGridCategory("Conditions").parent(".spg-panel").find(".spg-question__header");
+    const json = { "pages": [{ "name": "page1", "elements": [{ "type": "text", "name": "text", }] }] };
+    await setJSON(json);
+    await t.wait(1000);
+    await t.click(".svc-page", { offsetX: 5, offsetY: 5 });
+    await t.click(getPropertyGridCategory("Conditions"));
+    await t.drag(westResizer, 200, 0);
+    await takeElementScreenshot("helper-action.png", questionHeader, t, comparer);
+  });
+});