MetalLB: Add chart security profile #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hardys
approved these changes
Aug 21, 2024
hardys
changed the title
agracey
reviewed
Aug 21, 2024
| drop: | ||
| - ALL | ||
| seccompProfile: | ||
| type: RuntimeDefault |
There was a problem hiding this comment.
Not a blocker, just a question: Would it make sense to have these be defined in the values?
There was a problem hiding this comment.
Usually, that's how we handle the securityContext in the other charts and also it is more flexible because when you install the chart you can provide different context based on the use-case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
in the MetalLB and ECO chart's
podSecurityContext