-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rancher-turtles-airgap-resources chart #154
Conversation
45a2178
to
66556b7
Compare
Ok it looks like this won't work because we hit a helm size limitation - I don't see an obvious workaround atm so we'll have to find another way to create these configmaps for the airgap case:
|
a7be914
to
030fde2
Compare
To work around the size constraint I moved the new CMs into a separate chart |
See suse-edge/atip#7 for an example of how this works - only lightly tested at this point but now ready for wider review/test feedback, thanks! |
To simplify deployment in airgapped scenarios, this chart can deploy the necessary provider ConfigMap resources as described in the turtles and capi-operator docs
030fde2
to
b1dab8c
Compare
This aligns with the recently added suse-edge charts which enable management of CAPI dependencies via Rancher Turtles Depends On: suse-edge/charts#150 (merged) suse-edge/charts#154
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@Danil-Grigorev please could you take a look at this to check it's OK from the Rancher Turtles perspective? In future it might be nice if we solved this directly in Rancher Turtles somehow, but do you think this is a reasonable interim solution to simplify the install process for the Edge use-case (where we expect to only support specific providers/versions) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
One idea may be - depending on available sources, such as image registry accessible within the air-gapped environment or any OCI source; it may be possible to pre-load some ConfigMaps
with content and apply them into the cluster using additional tooling from this source. There was a ticket which was recently closed rancher/turtles#364 but can be addressed
Since there are no objections I'll merge this to make progress, then we can discuss if there's potential for a better or more general solution in future via rancher/turtles#364 |
Since we only plan to support specific providers in the edge wrapper chart, we can simplify the configuration for airgapped scenarios by always installing the provider components/yaml via ConfigMap resources as described in https://turtles.docs.rancher.com/getting-started/air-gapped-environment