Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rancher-turtles-airgap-resources chart #154

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

hardys
Copy link
Contributor

@hardys hardys commented Sep 10, 2024

Since we only plan to support specific providers in the edge wrapper chart, we can simplify the configuration for airgapped scenarios by always installing the provider components/yaml via ConfigMap resources as described in https://turtles.docs.rancher.com/getting-started/air-gapped-environment

@hardys hardys marked this pull request as draft September 10, 2024 17:55
@hardys hardys force-pushed the turtles_airgap branch 2 times, most recently from 45a2178 to 66556b7 Compare September 11, 2024 08:48
@hardys
Copy link
Contributor Author

hardys commented Sep 11, 2024

Ok it looks like this won't work because we hit a helm size limitation - I don't see an obvious workaround atm so we'll have to find another way to create these configmaps for the airgap case:

Error: UPGRADE FAILED: create: failed to create: Secret "sh.helm.release.v1.rancher-turtles.v3" is invalid: data: Too long: must have at most 1048576 bytes

@hardys
Copy link
Contributor Author

hardys commented Sep 11, 2024

To work around the size constraint I moved the new CMs into a separate chart

@hardys hardys changed the title [WIP] Rancher Turtles simplify airgap configuration Add rancher-turtles-airgap-resources chart Sep 11, 2024
@hardys hardys marked this pull request as ready for review September 11, 2024 12:50
@hardys
Copy link
Contributor Author

hardys commented Sep 11, 2024

See suse-edge/atip#7 for an example of how this works - only lightly tested at this point but now ready for wider review/test feedback, thanks!

To simplify deployment in airgapped scenarios, this chart can
deploy the necessary provider ConfigMap resources as described
in the turtles and capi-operator docs
hardys added a commit to hardys/suse-edge.github.io that referenced this pull request Sep 11, 2024
This aligns with the recently added suse-edge charts which enable
management of CAPI dependencies via Rancher Turtles

Depends On:
suse-edge/charts#150 (merged)
suse-edge/charts#154
Copy link
Contributor

@Kristian-ZH Kristian-ZH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hardys
Copy link
Contributor Author

hardys commented Sep 12, 2024

@Danil-Grigorev please could you take a look at this to check it's OK from the Rancher Turtles perspective?

In future it might be nice if we solved this directly in Rancher Turtles somehow, but do you think this is a reasonable interim solution to simplify the install process for the Edge use-case (where we expect to only support specific providers/versions)

Copy link

@Danil-Grigorev Danil-Grigorev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

One idea may be - depending on available sources, such as image registry accessible within the air-gapped environment or any OCI source; it may be possible to pre-load some ConfigMaps with content and apply them into the cluster using additional tooling from this source. There was a ticket which was recently closed rancher/turtles#364 but can be addressed

@hardys
Copy link
Contributor Author

hardys commented Sep 16, 2024

Since there are no objections I'll merge this to make progress, then we can discuss if there's potential for a better or more general solution in future via rancher/turtles#364

@hardys hardys merged commit f67a028 into suse-edge:main Sep 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants