Add endpoint copier operator component #45
Conversation
| @@ -0,0 +1,3 @@ | |||
| url: https://github.com/suse-edge/endpoint-copier-operator.git | |||
There was a problem hiding this comment.
Do you think we'll want to keep the chart in the endpoint-copier-operator repo long term, or move it into a package here similar to the other components?
There was a problem hiding this comment.
Keeping the chart in the endpoint-copier-operator repo was suggested in our Slack channel and the arguments were that in this way we keep the repo completed.
Akri follows the same approach.
| servicetype: kubernetes-vip | ||
| spec: | ||
| ports: | ||
| - name: rke2-api |
There was a problem hiding this comment.
This will fail as cannot be two ports with the same name. I suggest to keep this one as rke2-api but the other one rename it as k8s-api
There was a problem hiding this comment.
Also in this case, k3s doesn't need 9345, it is just rke2
There was a problem hiding this comment.
They do not have the same name actually (rke2-api and rke2-api2)
There was a problem hiding this comment.
Also in this case, k3s doesn't need 9345, it is just rke2
The purpose of the test is to test if the endpoint-copier-operator will create the endpoint with two ports successfully.
The test just needs to create a Service with two random ports and see what will happen with the endpoint
There was a problem hiding this comment.
I will change the name of the ports to port1 and port2 just to not make any confusions
Kristian-ZH
force-pushed
the
add-endpoint-copier-operator-component
branch
from
d555760
to
4c36aaf
Compare
Add endpoint-copier-operator package and define a GitHub action for it