Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Akri: Add discoveryHandlerName annotation to discovery handler daemon sets #52

Merged
merged 1 commit into from
Nov 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified assets/akri/akri-0.10.4.tgz
Binary file not shown.
23 changes: 23 additions & 0 deletions charts/akri/0.10.4/.helmignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# Patterns to ignore when building packages.
# This supports shell glob matching, relative path matching, and
# negation (prefixed with !). Only one pattern per line.
.DS_Store
# Common VCS dirs
.git/
.gitignore
.bzr/
.bzrignore
.hg/
.hgignore
.svn/
# Common backup files
*.swp
*.bak
*.tmp
*.orig
*~
# Various IDEs
.project
.idea/
*.tmproj
.vscode/
4 changes: 4 additions & 0 deletions charts/akri/0.10.4/templates/custom-discovery-handler.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ apiVersion: apps/v1
kind: DaemonSet
metadata:
name: {{ printf "%s-daemonset" .Values.custom.discovery.name }}
{{- if .Values.custom.discovery.discoveryHandlerName }}
annotations:
akri.sh/discoveryHandlerName: {{ .Values.custom.discovery.discoveryHandlerName }}
{{- end }}
spec:
selector:
matchLabels:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ apiVersion: apps/v1
kind: DaemonSet
metadata:
name: akri-debug-echo-discovery-daemonset
annotations:
akri.sh/discoveryHandlerName: debugEcho
spec:
selector:
matchLabels:
Expand Down
2 changes: 2 additions & 0 deletions charts/akri/0.10.4/templates/onvif-discovery-handler.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ apiVersion: apps/v1
kind: DaemonSet
metadata:
name: akri-onvif-discovery-daemonset
annotations:
akri.sh/discoveryHandlerName: onvif
spec:
selector:
matchLabels:
Expand Down
2 changes: 2 additions & 0 deletions charts/akri/0.10.4/templates/opcua-discovery-handler.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ apiVersion: apps/v1
kind: DaemonSet
metadata:
name: akri-opcua-discovery-daemonset
annotations:
akri.sh/discoveryHandlerName: opcua
spec:
selector:
matchLabels:
Expand Down
2 changes: 2 additions & 0 deletions charts/akri/0.10.4/templates/udev-discovery-handler.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ apiVersion: apps/v1
kind: DaemonSet
metadata:
name: akri-udev-discovery-daemonset
annotations:
akri.sh/discoveryHandlerName: udev
spec:
selector:
matchLabels:
Expand Down
2 changes: 2 additions & 0 deletions charts/akri/0.10.4/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,8 @@ custom:
protocol: TCP
# discovery defines a set of values for a custom discovery handler DaemonSet
discovery:
# exposes discovery handler name as akri.sh/discoveryHandlerName annotation on the DaemonSet
discoveryHandlerName: ''
# enabled defines whether discovery handler pods will be deployed in a slim Agent scenario
enabled: false
# name is the Kubernetes resource name that will be created for this
Expand Down
4 changes: 2 additions & 2 deletions index.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ entries:
catalog.cattle.io/display-name: Akri
apiVersion: v2
appVersion: 0.10.4
created: "2023-10-17T12:11:17.567764+03:00"
created: "2023-11-15T12:03:33.8679+01:00"
description: A Helm chart for Akri
digest: 9fe62e9e460526afbae804231d735eece837c5543bf5832a5b6553e6164b63ae
digest: 3b204151383d9a86d691eb6bb363f1509fa2d2c838982307ddb697ebfc0b0c4c
name: akri
type: application
urls:
Expand Down
23 changes: 23 additions & 0 deletions packages/akri/generated-changes/overlay/.helmignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# Patterns to ignore when building packages.
# This supports shell glob matching, relative path matching, and
# negation (prefixed with !). Only one pattern per line.
.DS_Store
# Common VCS dirs
.git/
.gitignore
.bzr/
.bzrignore
.hg/
.hgignore
.svn/
# Common backup files
*.swp
*.bak
*.tmp
*.orig
*~
# Various IDEs
.project
.idea/
*.tmproj
.vscode/
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
--- charts-original/templates/custom-discovery-handler.yaml
+++ charts/templates/custom-discovery-handler.yaml
@@ -3,6 +3,10 @@
kind: DaemonSet
metadata:
name: {{ printf "%s-daemonset" .Values.custom.discovery.name }}
+ {{- if .Values.custom.discovery.discoveryHandlerName }}
+ annotations:
+ akri.sh/discoveryHandlerName: {{ .Values.custom.discovery.discoveryHandlerName }}
+ {{- end }}
spec:
selector:
matchLabels:
\ No newline at end of file
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
--- charts-original/templates/debug-echo-discovery-handler.yaml
+++ charts/templates/debug-echo-discovery-handler.yaml
@@ -3,6 +3,8 @@
kind: DaemonSet
metadata:
name: akri-debug-echo-discovery-daemonset
+ annotations:
+ akri.sh/discoveryHandlerName: debugEcho
spec:
selector:
matchLabels:
\ No newline at end of file
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
--- charts-original/templates/onvif-discovery-handler.yaml
+++ charts/templates/onvif-discovery-handler.yaml
@@ -3,6 +3,8 @@
kind: DaemonSet
metadata:
name: akri-onvif-discovery-daemonset
+ annotations:
+ akri.sh/discoveryHandlerName: onvif
spec:
selector:
matchLabels:
\ No newline at end of file
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
--- charts-original/templates/opcua-discovery-handler.yaml
+++ charts/templates/opcua-discovery-handler.yaml
@@ -3,6 +3,8 @@
kind: DaemonSet
metadata:
name: akri-opcua-discovery-daemonset
+ annotations:
+ akri.sh/discoveryHandlerName: opcua
spec:
selector:
matchLabels:
\ No newline at end of file
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
--- charts-original/templates/udev-discovery-handler.yaml
+++ charts/templates/udev-discovery-handler.yaml
@@ -3,6 +3,8 @@
kind: DaemonSet
metadata:
name: akri-udev-discovery-daemonset
+ annotations:
+ akri.sh/discoveryHandlerName: udev
spec:
selector:
matchLabels:
\ No newline at end of file
11 changes: 11 additions & 0 deletions packages/akri/generated-changes/patch/values.yaml.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
--- charts-original/values.yaml
+++ charts/values.yaml
@@ -237,6 +237,8 @@
protocol: TCP
# discovery defines a set of values for a custom discovery handler DaemonSet
discovery:
+ # exposes discovery handler name as akri.sh/discoveryHandlerName annotation on the DaemonSet
+ discoveryHandlerName: ''
# enabled defines whether discovery handler pods will be deployed in a slim Agent scenario
enabled: false
# name is the Kubernetes resource name that will be created for this