Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use non-default namespace for CDI chart hooks #59

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Use non-default namespace for CDI chart hooks #59

merged 1 commit into from
Dec 12, 2023

Conversation

atanasdinov
Copy link
Contributor

  • Adds namespace hooks for CRD upgrades and removals
  • Replaces default namespace usage with said namespaces

@atanasdinov atanasdinov marked this pull request as ready for review December 6, 2023 15:48
ipetrov117
ipetrov117 approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@ipetrov117 ipetrov117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. General question, do we have plans to move away from the static sleep definitions inside the uninstall/upgrade jobs? Something like these suggestions here and here.

@atanasdinov
Copy link
Contributor Author

Yes, this is still something to be investigated. I prefer smaller PRs addressing only a single thing in order to make the testing and review processes easier though.

@atanasdinov atanasdinov merged commit 2e826a9 into main Dec 12, 2023
1 check passed
@atanasdinov atanasdinov deleted the cdi-hooks-namespace branch December 12, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ipetrov117 ipetrov117 ipetrov117 approved these changes

@e-minguez e-minguez Awaiting requested review from e-minguez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atanasdinov @ipetrov117