Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use release namespace in CDI #67

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Use release namespace in CDI #67

merged 2 commits into from
Dec 19, 2023

Conversation

atanasdinov
Copy link
Contributor

@atanasdinov atanasdinov commented Dec 15, 2023 •
edited
Loading

  • Extracted the namespace resource out of the operator manifest
  • Chart is now installable via helm install cdi <chart-repo> -n <namespace> --create-namespace
  • Upgrade and deletion flows are confirmed to be working properly

@atanasdinov atanasdinov marked this pull request as ready for review December 15, 2023 17:43
e-minguez
e-minguez approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@e-minguez e-minguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If tested and working let's merge it!

@e-minguez e-minguez merged commit 1ecfaaf into main Dec 19, 2023
1 check passed
@e-minguez e-minguez deleted the cdi-namespace branch December 19, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e-minguez e-minguez e-minguez approved these changes

@ipetrov117 ipetrov117 Awaiting requested review from ipetrov117

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atanasdinov @e-minguez