Enable TLS for image-cache webserver #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means we can use https for the image references from the BMH Note this will require suse-edge/charts#130
This previously seemed to work, but with the latest Leap Micro build there are python dependency issues, so instead only run the the hypervisor host and copy the kubeconfig via ssh
Use the latest released version, intead of main
|
This is now ready for review - I had to make a couple of additional changes due to updates in upstream LeapMicro and local-path-provisioner dependencies |
alknopfler
approved these changes
Jun 21, 2024
| @@ -1,7 +1,9 @@ | |||
| --- | |||
| metal3_repo_url: https://github.com/suse-edge/charts.git | |||
| metal3_branch: main | |||
| metal3_chart_version: 0.6.5 | |||
|
|
|||
| metal3_chart_version: 0.7.2 | |||
There was a problem hiding this comment.
I guess this is include also the reprovisioning patch at the same time, right? But I'm wondering if we can make it already available.
There was a problem hiding this comment.
Yes I aligned with the latest upstream version ref suse-edge/charts#133 even though the downstream release of this is still pending
hardys
changed the title
Kristian-ZH
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means we can use https for the image references from the BMH
Note this will require suse-edge/charts#130