Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added longhorn via fleet #38

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Added longhorn via fleet #38

merged 1 commit into from
Jun 23, 2023

Conversation

e-minguez
Copy link
Contributor

No description provided.

@e-minguez e-minguez marked this pull request as draft June 20, 2023 11:27
@e-minguez
Copy link
Contributor Author

Until rancher/fleet#1507 is released, it won't work

@e-minguez
Copy link
Contributor Author

For the UI https://k3s.rocks/basic-auth/ it would be nice to expose it with user authentication.
Also, I'm looking for a way to be able to customize the ingress host...

@e-minguez e-minguez force-pushed the longhorn-fleet branch 4 times, most recently from 398de88 to 7dad6d6 Compare June 21, 2023 12:34
@e-minguez e-minguez marked this pull request as ready for review June 21, 2023 12:34
@e-minguez e-minguez force-pushed the longhorn-fleet branch 5 times, most recently from 77469de to a07a1f9 Compare June 21, 2023 15:14
@e-minguez e-minguez changed the title Added longhorn via fleet Draft: Added longhorn via fleet Jun 21, 2023
@e-minguez e-minguez force-pushed the longhorn-fleet branch 7 times, most recently from 780a0a6 to 1acb460 Compare June 22, 2023 17:45
@e-minguez e-minguez changed the title Draft: Added longhorn via fleet Added longhorn via fleet Jun 22, 2023
@e-minguez
Copy link
Contributor Author

For the UI https://k3s.rocks/basic-auth/ it would be nice to expose it with user authentication. Also, I'm looking for a way to be able to customize the ingress host...

done

@e-minguez
Copy link
Contributor Author

Until rancher/fleet#1507 is released, it won't work

Added a note in the readme

Kristian-ZH
Kristian-ZH approved these changes Jun 23, 2023
View reviewed changes
Copy link
Contributor

@Kristian-ZH Kristian-ZH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We decided to merge the PR as it is now and to address my comment in a separate issue:
Ref #41

@Kristian-ZH Kristian-ZH merged commit 13a1fab into main Jun 23, 2023
@Kristian-ZH Kristian-ZH deleted the longhorn-fleet branch June 23, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kristian-ZH Kristian-ZH Kristian-ZH approved these changes

@atanasdinov atanasdinov Awaiting requested review from atanasdinov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@e-minguez @Kristian-ZH