Add OS and k8s util tests (#77)

* Add supported nodes validation tests Signed-off-by: Atanas Dinov <[email protected]> * Fix test failures Signed-off-by: Atanas Dinov <[email protected]> * Add OS upgrade check tests Signed-off-by: Atanas Dinov <[email protected]> * Add Kubernetes upgraded check tests Signed-off-by: Atanas Dinov <[email protected]> * Add control plane check tests Signed-off-by: Atanas Dinov <[email protected]> * Add target kubernetes version tests Signed-off-by: Atanas Dinov <[email protected]> --------- Signed-off-by: Atanas Dinov <[email protected]>
suse-edge · Sep 10, 2024 · e086c05 · e086c05
1 parent 05331c7
commit e086c05
Show file tree

Hide file tree

Showing 4 changed files with 460 additions and 5 deletions.
diff --git a/internal/controller/reconcile_kubernetes_test.go b/internal/controller/reconcile_kubernetes_test.go
@@ -0,0 +1,235 @@
+package controller
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+	lifecyclev1alpha1 "github.com/suse-edge/upgrade-controller/api/v1alpha1"
+
+	corev1 "k8s.io/api/core/v1"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/apimachinery/pkg/labels"
+)
+
+func TestIsKubernetesUpgraded(t *testing.T) {
+	const kubernetesVersion = "v1.30.3+k3s1"
+
+	nodeLabels := map[string]string{
+		"node-x": "z",
+	}
+
+	tests := []struct {
+		name            string
+		nodes           *corev1.NodeList
+		selector        labels.Selector
+		expectedUpgrade bool
+	}{
+		{
+			name: "All matching nodes upgraded",
+			nodes: &corev1.NodeList{
+				Items: []corev1.Node{
+					{
+						ObjectMeta: metav1.ObjectMeta{Labels: nodeLabels},
+						Spec:       corev1.NodeSpec{Unschedulable: false},
+						Status: corev1.NodeStatus{
+							Conditions: []corev1.NodeCondition{{Type: corev1.NodeReady, Status: corev1.ConditionTrue}},
+							NodeInfo:   corev1.NodeSystemInfo{KubeletVersion: "v1.30.3+k3s1"}},
+					},
+					{
+						ObjectMeta: metav1.ObjectMeta{Labels: nodeLabels},
+						Spec:       corev1.NodeSpec{Unschedulable: false},
+						Status: corev1.NodeStatus{
+							Conditions: []corev1.NodeCondition{{Type: corev1.NodeReady, Status: corev1.ConditionTrue}},
+							NodeInfo:   corev1.NodeSystemInfo{KubeletVersion: "v1.30.3+k3s1"}},
+					},
+					{
+						Status: corev1.NodeStatus{
+							Conditions: []corev1.NodeCondition{{Type: corev1.NodeReady, Status: corev1.ConditionTrue}},
+							NodeInfo:   corev1.NodeSystemInfo{KubeletVersion: "v1.28.12+k3s1"}},
+					},
+				},
+			},
+			selector:        labels.SelectorFromSet(nodeLabels),
+			expectedUpgrade: true,
+		},
+		{
+			name: "Unschedulable matching node",
+			nodes: &corev1.NodeList{
+				Items: []corev1.Node{
+					{
+						ObjectMeta: metav1.ObjectMeta{Labels: nodeLabels},
+						Spec:       corev1.NodeSpec{Unschedulable: true},
+						Status: corev1.NodeStatus{
+							Conditions: []corev1.NodeCondition{{Type: corev1.NodeReady, Status: corev1.ConditionTrue}},
+							NodeInfo:   corev1.NodeSystemInfo{KubeletVersion: "v1.30.3+k3s1"}},
+					},
+					{
+						ObjectMeta: metav1.ObjectMeta{Labels: nodeLabels},
+						Spec:       corev1.NodeSpec{Unschedulable: false},
+						Status: corev1.NodeStatus{
+							Conditions: []corev1.NodeCondition{{Type: corev1.NodeReady, Status: corev1.ConditionTrue}},
+							NodeInfo:   corev1.NodeSystemInfo{KubeletVersion: "v1.30.3+k3s1"}},
+					},
+					{
+						Status: corev1.NodeStatus{
+							Conditions: []corev1.NodeCondition{{Type: corev1.NodeReady, Status: corev1.ConditionTrue}},
+							NodeInfo:   corev1.NodeSystemInfo{KubeletVersion: "v1.28.12+k3s1"}},
+					},
+				},
+			},
+			selector:        labels.SelectorFromSet(nodeLabels),
+			expectedUpgrade: false,
+		},
+		{
+			name: "Not ready matching node",
+			nodes: &corev1.NodeList{
+				Items: []corev1.Node{
+					{
+						ObjectMeta: metav1.ObjectMeta{Labels: nodeLabels},
+						Spec:       corev1.NodeSpec{Unschedulable: false},
+						Status: corev1.NodeStatus{
+							Conditions: []corev1.NodeCondition{{Type: corev1.NodeReady, Status: corev1.ConditionFalse}},
+							NodeInfo:   corev1.NodeSystemInfo{KubeletVersion: "v1.30.3+k3s1"}},
+					},
+					{
+						ObjectMeta: metav1.ObjectMeta{Labels: nodeLabels},
+						Spec:       corev1.NodeSpec{Unschedulable: false},
+						Status: corev1.NodeStatus{
+							Conditions: []corev1.NodeCondition{{Type: corev1.NodeReady, Status: corev1.ConditionTrue}},
+							NodeInfo:   corev1.NodeSystemInfo{KubeletVersion: "v1.30.3+k3s1"}},
+					},
+					{
+						Status: corev1.NodeStatus{
+							Conditions: []corev1.NodeCondition{{Type: corev1.NodeReady, Status: corev1.ConditionTrue}},
+							NodeInfo:   corev1.NodeSystemInfo{KubeletVersion: "v1.28.12+k3s1"}},
+					},
+				},
+			},
+			selector:        labels.SelectorFromSet(nodeLabels),
+			expectedUpgrade: false,
+		},
+		{
+			name: "Matching node on older Kubernetes version",
+			nodes: &corev1.NodeList{
+				Items: []corev1.Node{
+					{
+						ObjectMeta: metav1.ObjectMeta{Labels: nodeLabels},
+						Spec:       corev1.NodeSpec{Unschedulable: false},
+						Status: corev1.NodeStatus{
+							Conditions: []corev1.NodeCondition{{Type: corev1.NodeReady, Status: corev1.ConditionTrue}},
+							NodeInfo:   corev1.NodeSystemInfo{KubeletVersion: "v1.28.12+k3s1"}},
+					},
+					{
+						ObjectMeta: metav1.ObjectMeta{Labels: nodeLabels},
+						Spec:       corev1.NodeSpec{Unschedulable: false},
+						Status: corev1.NodeStatus{
+							Conditions: []corev1.NodeCondition{{Type: corev1.NodeReady, Status: corev1.ConditionTrue}},
+							NodeInfo:   corev1.NodeSystemInfo{KubeletVersion: "v1.30.3+k3s1"}},
+					},
+					{
+						Status: corev1.NodeStatus{
+							Conditions: []corev1.NodeCondition{{Type: corev1.NodeReady, Status: corev1.ConditionTrue}},
+							NodeInfo:   corev1.NodeSystemInfo{KubeletVersion: "v1.28.12+k3s1"}},
+					},
+				},
+			},
+			selector:        labels.SelectorFromSet(nodeLabels),
+			expectedUpgrade: false,
+		},
+	}
+
+	for _, test := range tests {
+		t.Run(test.name, func(t *testing.T) {
+			assert.Equal(t, test.expectedUpgrade, isKubernetesUpgraded(test.nodes, test.selector, kubernetesVersion))
+		})
+	}
+}
+
+func TestControlPlaneOnlyCluster(t *testing.T) {
+	assert.True(t, controlPlaneOnlyCluster(&corev1.NodeList{
+		Items: []corev1.Node{
+			{ObjectMeta: metav1.ObjectMeta{Labels: map[string]string{"node-role.kubernetes.io/control-plane": "true"}}},
+			{ObjectMeta: metav1.ObjectMeta{Labels: map[string]string{"node-role.kubernetes.io/control-plane": "true"}}},
+		},
+	}))
+
+	assert.False(t, controlPlaneOnlyCluster(&corev1.NodeList{
+		Items: []corev1.Node{
+			{ObjectMeta: metav1.ObjectMeta{Labels: map[string]string{"node-role.kubernetes.io/control-plane": "true"}}},
+			{ObjectMeta: metav1.ObjectMeta{Labels: map[string]string{"node-role.kubernetes.io/control-plane": "false"}}},
+		},
+	}))
+
+	assert.False(t, controlPlaneOnlyCluster(&corev1.NodeList{
+		Items: []corev1.Node{
+			{ObjectMeta: metav1.ObjectMeta{Labels: map[string]string{"node-role.kubernetes.io/control-plane": "true"}}},
+			{ObjectMeta: metav1.ObjectMeta{Labels: map[string]string{}}},
+		},
+	}))
+
+	assert.False(t, controlPlaneOnlyCluster(&corev1.NodeList{
+		Items: []corev1.Node{
+			{ObjectMeta: metav1.ObjectMeta{Labels: map[string]string{}}},
+		},
+	}))
+}
+
+func TestTargetKubernetesVersion(t *testing.T) {
+	kubernetes := &lifecyclev1alpha1.Kubernetes{
+		K3S: lifecyclev1alpha1.KubernetesDistribution{
+			Version: "v1.30.3+k3s1",
+		},
+		RKE2: lifecyclev1alpha1.KubernetesDistribution{
+			Version: "v1.30.3+rke2r1",
+		},
+	}
+
+	tests := []struct {
+		name            string
+		nodes           *corev1.NodeList
+		expectedVersion string
+		expectedError   string
+	}{
+		{
+			name:          "Empty node list",
+			nodes:         &corev1.NodeList{},
+			expectedError: "unable to determine current kubernetes version due to empty node list",
+		},
+		{
+			name: "Unsupported Kubernetes version",
+			nodes: &corev1.NodeList{
+				Items: []corev1.Node{{Status: corev1.NodeStatus{NodeInfo: corev1.NodeSystemInfo{KubeletVersion: "v1.30.3"}}}},
+			},
+			expectedError: "upgrading from kubernetes version v1.30.3 is not supported",
+		},
+		{
+			name: "Target k3s version",
+			nodes: &corev1.NodeList{
+				Items: []corev1.Node{{Status: corev1.NodeStatus{NodeInfo: corev1.NodeSystemInfo{KubeletVersion: "v1.28.12+k3s1"}}}},
+			},
+			expectedVersion: "v1.30.3+k3s1",
+		},
+		{
+			name: "Target RKE2 version",
+			nodes: &corev1.NodeList{
+				Items: []corev1.Node{{Status: corev1.NodeStatus{NodeInfo: corev1.NodeSystemInfo{KubeletVersion: "v1.28.12+rke2r1"}}}},
+			},
+			expectedVersion: "v1.30.3+rke2r1",
+		},
+	}
+
+	for _, test := range tests {
+		t.Run(test.name, func(t *testing.T) {
+			version, err := targetKubernetesVersion(test.nodes, kubernetes)
+			if test.expectedError != "" {
+				require.Error(t, err)
+				assert.EqualError(t, err, test.expectedError)
+				assert.Empty(t, version)
+			} else {
+				require.NoError(t, err)
+				assert.Equal(t, test.expectedVersion, version)
+			}
+		})
+	}
+}
diff --git a/internal/controller/reconcile_os.go b/internal/controller/reconcile_os.go
@@ -129,7 +129,7 @@ func validateOSArch(nodeList *corev1.NodeList, supportedArchs []lifecyclev1alpha
 	for _, node := range nodeList.Items {
 		nodeArch := node.Status.NodeInfo.Architecture
 		if _, ok := supportedArchMap[nodeArch]; !ok {
-			return fmt.Errorf("unsuported arch '%s' for '%s' node. Supported archs: %s", nodeArch, node.Name, supportedArchs)
+			return fmt.Errorf("unsupported arch '%s' for '%s' node. Supported archs: %s", nodeArch, node.Name, supportedArchs)
 		}
 	}