Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce any/eslint warnings #671

Merged
merged 6 commits into from
Dec 4, 2019
Merged

Reduce any/eslint warnings #671

merged 6 commits into from
Dec 4, 2019

Conversation

brudil
Copy link
Contributor

@brudil brudil commented Dec 4, 2019

We should be following eslint, but currently we have a fair few warnings - mostly ts rules disallowing any which was used a fair bit in the initial port to TypeScript.

This PR is about getting our warning count down. Once down, we will add running eslint to our CI and Danger.

@brudil
Copy link
Contributor Author

brudil commented Dec 4, 2019

Okay - we're down to ~600 from ~1100. The rest are overuse of any - these will be fixed within their own product-centered refactors. I've opened #674 for using schema-dts for typing JsonLd, and #672 for experimenting with automatic typing from GraphQL

@brudil brudil marked this pull request as ready for review December 4, 2019 11:54
@brudil brudil requested a review from eirarangel December 4, 2019 11:54
@brudil
Copy link
Contributor Author

brudil commented Dec 4, 2019

Few typing issues with Slates left to fix

@brudil brudil merged commit 43b837f into master Dec 4, 2019
@brudil brudil deleted the brudil/eslint-fixes branch December 4, 2019 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eirarangel eirarangel eirarangel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brudil @eirarangel