10_inference_in_bayesian_networks_1 #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliash98
reviewed
Dec 24, 2021
| @@ -0,0 +1,201 @@ | |||
| # Inference in Bayes Nets 1 | |||
|
|
|||
There was a problem hiding this comment.
Well done with your Lecture Note! You've done a great job!
These few comments will help your LN get the best possible score:
- Consider resizing your images; Some of them are excessively large
- Your formulas are not correctly processed and represented by Github. For example, you've put
$x_i$ and Github has put this exact thing on the final page. Lots of students have had this problem, reach out to them and fix it. Btw, I am visiting your LN via this link: https://github.com/Parsa2820/notes/blob/lecturenote/10_bayesNetInference/notebooks/10_inference_in_bayesian_networks_1/index.md - If the texts get "Justified", then the article will look much better.
There was a problem hiding this comment.
Thanks for your review. We appreciate your suggestions.
- Images sizes were specified, but Github ignored them. I replaced the
divHTML tag withp, which is now correctly shown. - The whole document is now justified, and yes, it looks much better!
About the second suggestion, Github does not support math equations (there is an open issue for that), but Mr. Zehtab (@vahidzee ) have mentioned in Telegram that equations will be shown up in the Webifier after deployment. We have already tested the equations in our editor (VSCode), and they seem sound. By the way, if there is still a problem with them, we will be happy to solve them.
* Initial commit * Add intro * Add enumeration details * Add VE * Add ordering for VE * Update TOC * Add conditioning example * Change images size * Add comparison image * Fix some language mistakes * Add ordering image * Add class slide to references * Fix images size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AI Course Lecture Note
@aliash98