fix: do not mutate children in deeper levels
#947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathieuDerelle
commented
Nov 2, 2023
Comment on lines
+138
to
+154
| updateValue($event: any): void { | ||
| // removing must be done before adding | ||
| // in order for the event `moved` to work properly | ||
| const dataForRemoving = $event.removed || $event.moved; | ||
| if (dataForRemoving) { | ||
| this.localValue.children.splice(dataForRemoving.oldIndex, 1); | ||
| } | ||
|
|
||
| const dataForAdding = $event.added || $event.moved; | ||
| if (dataForAdding) { | ||
| this.localValue.children.splice( | ||
| dataForAdding.newIndex, | ||
| 0, | ||
| dataForAdding.element | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
the mutating error is fixed by the 2 other changes that create a shallow copy of children for localValue
but without this change, a strange bug appears :
Screen.Recording.2023-11-02.at.15.22.15.mov
on drag/drop, multiple updates occur :
- the child "test 2" gets updated with its now 4 children
- the parent "Plats cuisinés" gets updated with its now only 1 child "test 2" (but the value passed of "test 2" has only the 3 original children, not the now 4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #946