Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Swift PM compatibility by creating a separate ObjC target #428

Merged
merged 1 commit into from
Jul 29, 2022

Conversation

asolovev
Copy link
Contributor

@asolovev asolovev commented Jun 9, 2022

Swift Package Manager compatibility got broken after adding Objective-C source code #415 . There are multiple ways to fix it:

While I think making this project Swift-only is better, I made this PR to just fix the Swift Package Manager while keeping the implementation intact.

Other changes are targeted to fix the bundled resources that were not available in the Swift Package #400 . And to make sure that the framework can still be build from the project file (conditional imports are used for Swift PM or project compilation).

For me it has solved the Swift Package Manager problems, but I didn't check if CocoaPods and Carthage work. I did check that the project file allows to build the framework though.

Move Objectve-C files to a separate folder and target.
@rserentill
Copy link

@suzuki-0000 can we merge this in order to use SKPhotoBrowser with SPM?

@suzuki-0000
Copy link
Owner

@rserentill thank you for the support 👍 👍
you can merge this. (let me merge at this time

@suzuki-0000 suzuki-0000 merged commit 6577850 into suzuki-0000:master Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants