Doc review 2023 03 round 01 #869
+49
−45
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| #ifndef _DAGMC_LOGGER | ||
| #define _DAGMC_LOGGER | ||
|
|
||
| #include <iostream> | ||
| #include <string> | ||
|
|
||
| class DagMC_Logger { | ||
| public: | ||
| DagMC_Logger(int _verbosity = 1) { set_verbosity(_verbosity); }; | ||
|
|
||
| void set_verbosity(int val) { | ||
| int verbosity_min = 0; | ||
| int verbosity_max = 1; | ||
| if (val < verbosity_min || val > verbosity_max) | ||
| warning("Invalid verbosity value " + std::to_string(val) + | ||
| " will be set to nearest valid value."); | ||
| val = std::min(std::max(verbosity_min, val), verbosity_max); | ||
| verbosity = val; | ||
| } | ||
|
|
||
| int get_verbosity() const { return verbosity; }; | ||
|
|
||
| void message(const std::string& msg, int lvl = 1, bool newline = true) const { | ||
| if (lvl > verbosity) return; | ||
| std::cout << msg; | ||
|
|
||
| if (newline) std::cout << "\n"; | ||
| } | ||
|
|
||
| void warning(const std::string& msg, int lvl = 1, bool newline = true) const { | ||
| message("WARNING: " + msg, -1, newline); | ||
| } | ||
|
|
||
| void error(const std::string& msg, bool newline = true) const { | ||
| std::cerr << "ERROR: " << msg; | ||
| if (newline) std::cerr << "\n"; | ||
| } | ||
|
|
||
| private: | ||
| int verbosity{1}; | ||
| }; | ||
|
|
||
| #endif |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this need to be between
5.10and5.3.0again? I thought we could also support newer versions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are significant changes in v5.4.0 that are causing some build fail. We need to resolve this issue before proceeding to v5.4 MOAB.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see. Perhaps we could clarify that the restriction to 5.4.0 is only for Windows if that is the case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our CI is stuck on 5.3.0 until we can figure out all the issues. It's a limitation for Ubuntu as well for 20.04 and older - seems to work on 22.04, though.
With all those caveats, it's seems best to stick with 5.3.0 for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough! Strange though... hopefully we can figure it out someday.