add 1.11.2 geant4 to routine build testing #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We are getting DD fail after last merge! |
|
Oops! Sorry. DD is failing every time. I may create a PR. It might be due to some configuration error. |
|
It's a known issue that DD fails and it fails in an advisory way. @pshriwise is working on a release of DD to fix this |
|
Sorry to nag @shimwell or @pshriwise but this really is the end before a release and hopefully more regular releases and conda-forge updates and working towards a pip installable... etc |
|
This looks straightforward to me. Adding another version to the matrix. All the Ci checks passed. Doesn't look like there is much to review here unless I'm missing something |
shimwell
approved these changes
Dec 8, 2023
|
You can go ahead and merge @shimwell |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add routine testing against Geant4 1.11.2 now that the docker images support it.
I promise this is the last step in getting the Geant4 update done.