Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MOAB to latest #939

Merged
merged 5 commits into from
Feb 13, 2024
Merged

Update MOAB to latest #939

merged 5 commits into from
Feb 13, 2024

Conversation

ahnaf-tahmid-chowdhury
Copy link
Member

Update MOAB to 5.5.1

gonuke
gonuke requested changes Feb 13, 2024
View reviewed changes
Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to update this in docker_publish.yml before we can then also update in linux_build_test.yml - ideally in 2 separate PRs

@ahnaf-tahmid-chowdhury
Copy link
Member Author

Sorry, I missed to update docker_publish.yml. Thanks!

@ahnaf-tahmid-chowdhury
Copy link
Member Author

Let's build both 5.4.1 and 5.5.1 images for the history. Later, we may stick with only 5.5.1?

@gonuke
Copy link
Member

gonuke commented Feb 13, 2024

This LGTM - thanks @ahnaf-tahmid-chowdhury

@gonuke gonuke merged commit 0b0ed3b into develop Feb 13, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gonuke gonuke gonuke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahnaf-tahmid-chowdhury @gonuke