Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid spurious failure in nearest_to fuzzer #150

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

finnbear
Copy link
Collaborator

Fixes a rare issue with the nearest_to fuzzer.

 thread '<unnamed>' panicked at fuzz_targets/fuzz.rs:356:13:
assert_abs_diff_eq!(best.1, flat_best.1)

    left  = 0.0003059545
    right = 0.00030377653

https://github.com/svenstaro/bvh/actions/runs/12971033150/job/36176984562?pr=149

@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 49.24%. Comparing base (e0b53e7) to head (29ab709).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
fuzz/fuzz_targets/fuzz.rs 0.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
- Coverage   49.31%   49.24%   -0.07%     
==========================================
  Files          17       17              
  Lines        1462     1462              
==========================================
- Hits          721      720       -1     
- Misses        741      742       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svenstaro svenstaro merged commit e61924c into svenstaro:master Jan 26, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants