Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: dont create diff png if no_diff #1903

Merged
merged 1 commit into from
Dec 25, 2023
Merged

ci: dont create diff png if no_diff #1903

merged 1 commit into from
Dec 25, 2023

Conversation

SethFalco
Copy link
Member

Makes two small changes:

  • When NO_DIFF is set, don't create an empty PNG to populate with diff data.
  • Set the viewport in the context instead of each page individually.

Metrics

Time to run the full SVGO Test Suite proposed in SethFalco#1.

Environment Time
GitHub Actions (2 cores) 20.2 minutes
My personal laptop (4 cores, 8 threads) 14.5 minutes

@SethFalco SethFalco merged commit 52961ba into svg:main Dec 25, 2023
10 checks passed
@SethFalco SethFalco deleted the test-nodiff branch December 25, 2023 14:06
@SethFalco SethFalco mentioned this pull request Dec 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SethFalco