Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(removeAttributesBySelector): update for v2 API, better docs, add parameter types #1978

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(removeAttributesBySelector): update for v2 API, better docs, add parameter types #1978

wants to merge 2 commits into from

Conversation

soren121
Copy link

@soren121 soren121 commented Apr 8, 2024 •
edited
Loading

This is a general cleanup PR for the removeAttributesBySelector plugin. It was never updated for the v2 API, and its doc page was not very clear on how to use it; this PR addresses both.

Changes

  • Plugin was updated to use the V2 API
  • Added a check to avoid runtime errors when plugin is not configured, or misconfigured
  • Added a test to ensure plugin is a no-op when not configured
  • Expanded and clarified the plugin's doc page
  • Added TypeScript parameter types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@soren121