Move svgstore to devDependencies and peerDependencies #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move svgstore to devDependencies and peerDependencies for the sake of having flexibility to change the used svgstore version outside of the plugin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move svgstore to devDependencies and peerDependencies for the sake of having the flexibility to change the used svgstore version outside of the plugin.
The thing is that we have to use our customized
svgstoresince we're experimenting a lot with the icons automatically exported from Sketch and keep those changes in a feature branch, which is not fully ready for a PR. So, it'd be great to have a possibility to pass our own svgstore to the broccoli plugin, and I was about to propose an option for the plugin, but having a peer dependency seems to me a more convenient way to have it done.