Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add workflow to check for uncommitted codegen changes #1748

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

svix-jplatte
Copy link
Member

@svix-jplatte svix-jplatte commented Feb 24, 2025

@svix-jplatte svix-jplatte marked this pull request as ready for review February 24, 2025 15:04
@svix-jplatte svix-jplatte requested a review from a team as a code owner February 24, 2025 15:04
@svix-mman
Copy link
Contributor

@svix-jplatte
Is the plan here to eventually check for uncommitted changes on all of the languages. Or is this workflow only for rust?

@svix-jplatte
Copy link
Member Author

This workflow checks for any changes done by regen_openapi.sh.
The plan is for that script to regenerate all of the libs (again).

@svix-mman
Copy link
Contributor

Is the long term plan is not to track the generated libs in git, Or we will regen in CI so we can verify that committed libs are up to date?

@svix-jplatte
Copy link
Member Author

svix-jplatte commented Feb 24, 2025

The long term plan is to continue tracking the generated libs in git, and have CI verify that any changes to the spec or templates are reflected in the libs / no manual changes were made to libs that the script would overwrite again. This PR adds that CI check, though it only affects Rust for now because that's the only lang the regen script affects that also has its source committed. Makes sense?

@svix-jplatte svix-jplatte merged commit 4d28ed6 into main Feb 24, 2025
16 checks passed
@svix-jplatte svix-jplatte deleted the jplatte/codegen-ci branch February 24, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants