Order MemberGroup by name by default #3452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ColonelPhantom
force-pushed
the
organiser-order
branch
from
e769596 to
7ed3ab6
Compare
DeD1rk
approved these changes
Nov 3, 2023
This wasn't ideal for the old i18n-capable version of concrexit, but we dropped that so the comment is outdated. This does likely mean some redundant sorting is done, but that's not an issue.
ColonelPhantom
force-pushed
the
organiser-order
branch
from
7ed3ab6 to
7708db8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #ISSUE.
Summary
@Scarletto wanted this for the effect on the events API. Ordering like this by default seems reasonable because i18n seems the only reason it wasn't done in the past and that's not a concern anymore.
How to test