Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alumni mailinglist missing people #3482

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

DeD1rk
Copy link
Member

@DeD1rk DeD1rk commented Nov 13, 2023

Closes #3435.

Summary

This changes the way the oldmembers mailinglist is determined to include alumni from before concrexit, of whom we often have no (accurate) membership history.

I branched off of the branch for #3420, as both will probably be in the same release, and it would need a harder rebase otherwise.

How to test

  1. Make a new member
  2. Check that they can set, unset and reset the receive_oldmembers setting.
  3. Make a new benefactor
  4. Check that they cannot set the receive_oldmembers setting to True.

@DeD1rk DeD1rk added app:mailinglists Issues regarding the mailinglists-app bug Something that should be fixed labels Nov 13, 2023
@DeD1rk DeD1rk force-pushed the fix-alumni-mailinglist-missing-people branch from 45dc158 to 98e1c8b Compare November 20, 2023 14:24
@DeD1rk DeD1rk marked this pull request as ready for review November 22, 2023 10:01
@DeD1rk DeD1rk force-pushed the fix-alumni-mailinglist-missing-people branch from 811210b to 9125e68 Compare December 12, 2023 14:43
Copy link
Contributor

@T8902 T8902 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@T8902 T8902 merged commit 2391a20 into master Dec 13, 2023
10 checks passed
@T8902 T8902 deleted the fix-alumni-mailinglist-missing-people branch December 13, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:mailinglists Issues regarding the mailinglists-app bug Something that should be fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

oldmembers mailinglist incomplete
2 participants