Add extra dropdowns for every year in payment history #3840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BPC2004
force-pushed
the
3839-view-all-payments
branch
from
725e5fa to
0697211
Compare
DeD1rk
reviewed
Nov 20, 2024
website/payments/views.py
Outdated
| @@ -145,14 +146,21 @@ def get_queryset(self) -> QuerySet: | |||
|
|
|||
| def get_context_data(self, *args, **kwargs): | |||
| filters = [] | |||
| for i in range(13): | |||
|
|
|||
| for i in range(85): | |||
There was a problem hiding this comment.
85 is kind of a weird number?... Is it based on the legal storage period for payment info? For the user it might be nice if years in which there were no payments (or at least years before their first payment) are not shown.
added 7 commits
December 11, 2024 20:35
… member or 7 years depends on which one is the later date.
… member or 7 years depends on which one is the later date.
| current_time = timezone.now().replace(tzinfo=None) | ||
| nr_months = 0 | ||
| earliest_membership = self.request.member.earliest_membership | ||
| difference = relativedelta(current_time, earliest_membership.since) |
There was a problem hiding this comment.
This crashes if a user with no memberships tries to open it:
There was a problem hiding this comment.
Suggestion that I think does not break code coverage: add if earliest_membership else None to the end of this line, and do the same but with else 0 for nr_months
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3839.
Summary
Made it so you can look through your payment history with the GUI.
How to test