Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/payment request new #3857

Closed
wants to merge 6 commits into from
Closed

Conversation

T8902
Copy link
Contributor

@T8902 T8902 commented Nov 27, 2024

Closes #3453 and #941.

Requirements

Implementation

  • We will extend the payment models with a PaymentRequest class, this model will store information about the request and the payment itself, it is also a Payable object. Each payed request will become immutable.

  • We will add an AdminView which shows all requests, but the default filter only shows 'pending' (unpaid) requests.

  • We will add an AdminView for editing pending requests.

  • There will be an AdminForm for adding new requests, here you can fill in details, and select any number of PaymentUsers (must be at least 1!) to whom the request apply.

  • !TODO think of how we would like to handle late-cancellation fines to happen with the payment-request system

  • After creating a new request the user should be notified, we will do this by e-mail and by pushnotification. An admin can send-on-save or do it manually later

Tasklist

  • setup model
  • write tests for model
  • admin views
  • admin view tests
  • admin form
  • admin form tests
  • notification time
  • email tests
  • a connection between fines and service
  • connection tests
  • (optional) reminder date

Summary

How to test

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'

Notes

  • How can we ensure that Users with an expired Membership can still pay (both before the PaymentRequest is created and after if they didn't pay yet but their membership did expire)?

@github-actions github-actions bot added the feature Issues regarding a complete new feature label Nov 27, 2024
@T8902 T8902 closed this Nov 27, 2024
@T8902 T8902 deleted the feature/payment_request_new branch November 27, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Issues regarding a complete new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overhaul Payables / miscellaneous Payables
1 participant