Optimize /api/v2/events by changing is_organiser logic #3883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ColonelPhantom
changed the title
ColonelPhantom
force-pushed
the
optimize-events-api-activemember
branch
from
e7aa227 to
0dca0d9
Compare
|
By the way, it might be beneficial to use the cached member_groups in other places too? Unsure about that, though. |
Cache member_groups Make logic in is_organiser more explicit Do explicit cache invalidation in test invalidate cache in more places fix
ColonelPhantom
force-pushed
the
optimize-events-api-activemember
branch
from
0dca0d9 to
3caf65e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3586.
Summary
Changes the
is_organiserlogic so that we need fewer (duplicate) queries by doing more work Python-side.This does require using
@cached_propertyformember.get_member_groups(), which can be a little error-prone but should be fine in practice.How to test
/api/v2/events