Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(bom createreleases): assure behaviour on diverging source URLs #96

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

gernot-h
Copy link
Collaborator

@gernot-h gernot-h commented Nov 6, 2024

This is a follow-up to #92 and adapts the URL in the test to the hard-coded pattern introduced there, to assure that we don't overwrite existing URLs in SW360 as discussed in #100.

In context of unconditional sourceUrl change introduced by commit
"feat: prevent uploading .git files", assure that existing, valid URLs
are not changed. The test introduced in d47fa16 is not enough, we need
to use a valid source URL.
@gernot-h gernot-h force-pushed the gernot/test-make-upload-more-robust branch from 9eedd65 to d5713bc Compare November 27, 2024 08:09
@gernot-h
Copy link
Collaborator Author

gernot-h commented Nov 27, 2024

@tngraf, if you want, you can also merge this change, it will slightly improve an existing test case to avoid we introduce a change similar to what was introduced in #92. Feel free to close if you think we don't need this test.

@gernot-h gernot-h changed the title Draft: test(bom createreleases): assure behaviour on diverging source URLs test(bom createreleases): assure behaviour on diverging source URLs Nov 27, 2024
@tngraf tngraf merged commit e2a2e27 into main Nov 27, 2024
7 checks passed
@gernot-h gernot-h deleted the gernot/test-make-upload-more-robust branch January 13, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants