Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(request-duration): Set response duration in failure cases #10064

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AndreMantas
Copy link

Description

Request duration is not being populated for non-200 responses

According to live-response.jsx the duration component will only be rendered if the response duration is set
https://github.com/swagger-api/swagger-ui/blob/master/src/core/components/live-response.jsx#L124

But that was not happening on the 'catch' block
https://github.com/swagger-api/swagger-ui/blob/master/src/core/plugins/spec/actions.js#L471-L487

Motivation and Context

Fixes #6618

How Has This Been Tested?

Unit tests

Screenshots (if appropriate):

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request duration is not showing when API respond with 400 status code
2 participants