Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Consistent usage of ≤ and ≥ when displaying min/max attributes #10159

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hkosova
Copy link
Contributor

@hkosova hkosova commented Oct 3, 2024

Description

See the screenshots below. When displaying min/max attributes of schema properties, the schema renderer used a mix of ≤ ≥ and >= <= characters. This inconsistency was bugging me, so I changed all uses to ≤ ≥. (If you prefer >= <=, let me know and I'll update the PR.)

OpenAPI spec for testing: https://gist.githubusercontent.com/hkosova/dc9ea2c285b61cd36a5ec8eb18b43676/raw/7defc7378734e7494d7ec3a2bf0928bc7fe9ff48/min-max.yaml

Motivation and Context

Consistency.

How Has This Been Tested?

Tested manually by comparing visual appearance before and after the change.

Screenshots (if appropriate):

Before:

After:

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant