-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 3859 Added support for oneOf and anyOf in array sample #4136
Merged
shockey
merged 14 commits into
swagger-api:master
from
PavelStefanov:bug/3859-array-oneOf-anyOf
Mar 3, 2018
Merged
Fix 3859 Added support for oneOf and anyOf in array sample #4136
shockey
merged 14 commits into
swagger-api:master
from
PavelStefanov:bug/3859-array-oneOf-anyOf
Mar 3, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just FYI, this example is not really valid schema:
type: array
items:
oneOf:
- type: string
- type: integer
example:
- oranges
- 15 It means an array item can have the literal value Multi-item examples (aka whole array examples) should be on the array level, not under schema:
type: array
items:
oneOf:
- type: string
- type: integer
example:
- oranges
- 15 Atomic item examples can be defined like so: items:
oneOf:
- type: string
example: oranges
- type: integer
example: 15
example: oranges |
@hkosova thank you for the clarification. I removed changes for examples and fixed tests |
shockey
approved these changes
Mar 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes #3859
Description
Added support for oneOf and anyOf properties in array sample.
it will look like this
Also fixed examples for array items.
before
now
Types of changes
Checklist: