Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwanContents: remove nbclassic's upgrade warning #352

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

SwanContents: remove nbclassic's upgrade warning #352

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion SwanContents/swancontents/swanclassic/notebookapp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@
from traitlets import Unicode
import datetime

from contextlib import redirect_stdout
import os


class NotebookApp(ClassicNotebookApp):
"""
Expand Down Expand Up @@ -49,7 +52,13 @@ def initialize_handlers(self):
handlers.extend(load_handlers("swancontents.swanclassic.handlers.cernbox"))
handlers.extend(load_handlers("swancontents.swanclassic.handlers.notebookviewer"))
self.handlers.extend(handlers)
super(NotebookApp, self).initialize_handlers()

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Questions:

  • This print happens many times or just once?
  • Should we say in the comment that this is temporary (until we upgrade notebook)?
  • Does this redirection also mask possible logs coming from initialize_handlers?

# When initializing the handlers, there's a a `print` that gives a warning to
# upgrade to notebook 7. By sending the print to dev/null, we don't pollute
# our container's logs
with open(os.devnull, 'w') as f:
with redirect_stdout(f):
super(NotebookApp, self).initialize_handlers()

def initialize_settings(self):
"""
Expand Down