Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add header and footer to Privacy Policy page #284

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

RachitSahu26
Copy link

@RachitSahu26 RachitSahu26 commented Oct 26, 2024

What does this PR do?

This pull request adds a header and footer to the Privacy Policy page, enhancing the user navigation and overall layout of the page.

Fixes: #268

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

To verify the changes, please follow these steps:

  1. Navigate to the Privacy Policy page in the application.
  2. Check if the header and footer are displayed correctly.
  3. Ensure that the header includes the correct links and branding.
  4. Verify that the footer includes all relevant information (e.g., copyright, links to other pages).
  5. Test responsiveness by resizing the browser window or checking on different devices.

Additional Tests

  • Ensure that the header and footer render correctly on all supported browsers.
  • Check for any console errors or warnings related to the header and footer components.
  • Verify that the header and footer do not interfere with the existing layout of the Privacy Policy content.

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.
  • Update any relevant documentation, if applicable.

Uploading footer and header.mp4…

Copy link

vercel bot commented Oct 26, 2024

@RachitSahu26 is attempting to deploy a commit to the Piyush's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you @RachitSahu26 for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better. Also, feel free to join our Discord server: Discord Link

Copy link
Owner

@swarooppatilx swarooppatilx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are some issues
Screenshot From 2024-10-26 15-12-27




curiousrachit26
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

???

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait i am fixing again it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants