Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed all issues #300

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

AswaniBolisetti
Copy link
Contributor

@swarooppatilx
Hey! Everything is working fine now
And someone removed the code for terms and conditions and i have added it again and enhanced the privacy policy page
Kindly check now

issue no : #293

fix.mp4

Copy link

vercel bot commented Oct 27, 2024

@AswaniBolisetti is attempting to deploy a commit to the Piyush's projects Team on Vercel.

A member of the Team first needs to authorize it.

@AswaniBolisetti
Copy link
Contributor Author

@swarooppatilx
Kindly merge this one, then I'll proceed with adding contact us page

@AswaniBolisetti
Copy link
Contributor Author

@swarooppatilx
Please merge this and consider it as level 3

Copy link
Owner

@swarooppatilx swarooppatilx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some issues with layout and dark mode

footer has shrunken in width
Screenshot From 2024-10-28 13-33-34

its not visible in dark mode
Screenshot From 2024-10-28 13-33-42

@swarooppatilx swarooppatilx added gssoc-ext GirlScript Summer of Code Extended 2024 level3 GirlScript Summer of Code Level 3 Issue hacktoberfest-accepted Hacktoberfest labels Oct 28, 2024
@AswaniBolisetti
Copy link
Contributor Author

@swarooppatilx
No while im working i didnt get this kind of issue,
ok let me check again

@AswaniBolisetti
Copy link
Contributor Author

@swarooppatilx
I resolved all the problems
Kindly check now

privacy7.mp4

@AswaniBolisetti
Copy link
Contributor Author

@swarooppatilx
Hey please check this once

app.js Outdated
@@ -377,9 +371,9 @@ app.get('/help', (req, res) => {
});
});

app.get('/support', (req, res) => {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have removed the /support page route

app.js Outdated
app.get('/support', (req, res) => {
res.render('support', {
activeLink: 'support', // You can customize this based on your layout
app.get('/terms-page', (req, res) => {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have added /terms-page route twice, this will throw errors

Copy link
Owner

@swarooppatilx swarooppatilx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lot of issues, please fix those

app.js Outdated
@@ -402,20 +396,6 @@ app.get('/market/form', ensureAuthenticated, (req, res) => {
res.render('form', { routeName: 'market', errors: [], activeLink: 'market' });
});

app.get('/:type/edit/:id', ensureAuthenticated, async (req, res) => {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have deleted route to edit post??

app.js Outdated
@@ -509,49 +489,6 @@ app.post(
}
);

app.post(
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this route is deleted? it is required to edit post

@AswaniBolisetti
Copy link
Contributor Author

@swarooppatilx
Ok I'll check
This may be due to conflicts

@AswaniBolisetti
Copy link
Contributor Author

@swarooppatilx
Hey please check once

@AswaniBolisetti
Copy link
Contributor Author

@swarooppatilx
If everything ok, please merge this, then i'll proceed with other issues

@AswaniBolisetti
Copy link
Contributor Author

@swarooppatilx
Please check once

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext GirlScript Summer of Code Extended 2024 hacktoberfest-accepted Hacktoberfest level3 GirlScript Summer of Code Level 3 Issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants