Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Master #59

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Master #59

wants to merge 6 commits into from

Commits on Sep 22, 2018

  1. Don't remember why we had to read().decode() it.

    mihail committed Sep 22, 2018
    Configuration menu
    Copy the full SHA
    3ef244f View commit details
    Browse the repository at this point in the history

  2. resource exception has all the fields separately

    mihail committed Sep 22, 2018
    Configuration menu
    Copy the full SHA
    15e3572 View commit details
    Browse the repository at this point in the history

  3. I don't remember why we did this

    mihail committed Sep 22, 2018
    Configuration menu
    Copy the full SHA
    d2a81b5 View commit details
    Browse the repository at this point in the history

  4. error code being returned

    mihail committed Sep 22, 2018
    Configuration menu
    Copy the full SHA
    b56e25b View commit details
    Browse the repository at this point in the history

  5. jsonify the output from pvesh

    mihail committed Sep 22, 2018
    Configuration menu
    Copy the full SHA
    23c5a17 View commit details
    Browse the repository at this point in the history

  6. Not all pvesh commands return http-like error code, if the command is… 

    … with exit status of 0, then it is successful. The exit status from the command is far more important that stdout/stderr when deciding if the command was successful or not.
    mihail committed Sep 22, 2018
    Configuration menu
    Copy the full SHA
    d1a9ecb View commit details
    Browse the repository at this point in the history