fix(html/minifier): Fix HTML minifier TS types #9615
Merged
+5
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
preserveComments
is optional but required in the TS typeremoveRedundantAttributes
is an enum and passing a boolean leads to errorsSee https://github.com/swc-project/swc/blob/main/crates/swc_html_minifier/src/option.rs#L54
Sync HTML minifier TS options with Rust options.
I'm not sure if I'm supposed to edit this file manually or if it's generated, but let's figure it out together 😄
BREAKING CHANGE: no, type bugfix
Related issue (if exists): facebook/docusaurus#10554