Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistent lowercase for filename #609

Merged
merged 2 commits into from
Mar 8, 2024
Merged

consistent lowercase for filename #609

merged 2 commits into from
Mar 8, 2024

Conversation

maneesha
Copy link
Contributor

@maneesha maneesha commented Jan 3, 2024

The second time the file script.R is referenced, it starts with a capital S. For consistency as file names are case sensitive, this PR changes it to lowercase.

The second time the file `script.R` is referenced, it starts with a capital S.  For consistency as file names are case sensitive, this PR changes it to lowercase.
Copy link

github-actions bot commented Jan 3, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/swcarpentry/r-novice-inflammation/compare/md-outputs..md-outputs-PR-609

The following changes were observed in the rendered markdown documents:

 01-starting-with-data.md    |   2 +-
 config.yaml (new)           |  95 +++++++++++
 data/car-speeds-cleaned.csv |  94 ++++++++++
 md5sum.txt                  |   2 +-
 renv.lock (new)             | 408 ++++++++++++++++++++++++++++++++++++++++++++
 5 files changed, 599 insertions(+), 2 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-03-08 23:37:59 +0000

github-actions bot pushed a commit that referenced this pull request Jan 3, 2024
Copy link
Member

@Bisaloo Bisaloo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! For future reference, the first occurrence is here:

- Create a new file where we will type our scripts. Go to File > New File > R
script. Click the save icon on your toolbar and save your script as
"`script.R`".

Should we also harmonize style ("`script.R`" vs `script.R`) in this PR?

@ErinBecker
Copy link
Contributor

Thank you @maneesha for correcting this inconsistency. I've harmonized the quotation mark styling as recommended by @Bisaloo.

@ErinBecker ErinBecker merged commit ea71489 into main Mar 8, 2024
3 checks passed
@ErinBecker ErinBecker deleted the lowercase-filename branch March 8, 2024 23:38
github-actions bot pushed a commit that referenced this pull request Mar 8, 2024
github-actions bot pushed a commit that referenced this pull request Mar 8, 2024
Auto-generated via {sandpaper}
Source  : ea71489
Branch  : main
Author  : Erin Becker <[email protected]>
Time    : 2024-03-08 23:38:58 +0000
Message : Merge pull request #609 from swcarpentry/lowercase-filename

consistent lowercase for filename
github-actions bot pushed a commit that referenced this pull request Mar 8, 2024
Auto-generated via {sandpaper}
Source  : b6fa1f8
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-03-08 23:40:06 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : ea71489
Branch  : main
Author  : Erin Becker <[email protected]>
Time    : 2024-03-08 23:38:58 +0000
Message : Merge pull request #609 from swcarpentry/lowercase-filename

consistent lowercase for filename
github-actions bot pushed a commit that referenced this pull request Mar 12, 2024
Auto-generated via {sandpaper}
Source  : b6fa1f8
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-03-08 23:40:06 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : ea71489
Branch  : main
Author  : Erin Becker <[email protected]>
Time    : 2024-03-08 23:38:58 +0000
Message : Merge pull request #609 from swcarpentry/lowercase-filename

consistent lowercase for filename
github-actions bot pushed a commit that referenced this pull request Mar 19, 2024
Auto-generated via {sandpaper}
Source  : b6fa1f8
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-03-08 23:40:06 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : ea71489
Branch  : main
Author  : Erin Becker <[email protected]>
Time    : 2024-03-08 23:38:58 +0000
Message : Merge pull request #609 from swcarpentry/lowercase-filename

consistent lowercase for filename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants