-
-
Notifications
You must be signed in to change notification settings - Fork 980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated path in 05-loop.md to be relative to home directory #1414
Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/swcarpentry/shell-novice/compare/md-outputs..md-outputs-PR-1414 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2023-07-23 08:00:48 +0000 |
Thanks for the contribution. The home directory may not be Desktop, so probably something further is needed. Typically in bash one can check the output of |
In the rest of the lesson, $ cd ~/Desktop/shell-lesson-data and in episodes/07-find.md (lines 44-45): $ cd
$ cd Desktop/shell-lesson-data/exercise-data/writing This is also consistent from episodes/02-filedir.md with the use of a Mac for the examples, where
In any case, the |
Not sure why, it uses
and change the text "starting from her home directory" to "moving to the north-pacific-gyre directory" or something similar. Alternatively, use
Since this will then move to the home directory |
Can look at other changes for consistent paths in a further change since the home directory maybe different, and changes will be needed through the entire lesson. |
In 0b441e9 I have amended the descriptive text to reference the directory moving to, and put in a I agree that consistent paths could be an issue throughout the whole lesson. Currently it seems consistent on a Mac (except for this section), but any system where Desktop is not in the home directory will have problems. There may not be an ideal solution to this. |
Auto-generated via {sandpaper} Source : 506e621 Branch : main Author : Benson Muite <[email protected]> Time : 2023-07-23 08:38:52 +0000 Message : Merge pull request #1414 from theabro/05-path-update updated path in 05-loop.md to be relative to home directory
Auto-generated via {sandpaper} Source : 57c51cc Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2023-07-23 08:40:08 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 506e621 Branch : main Author : Benson Muite <[email protected]> Time : 2023-07-23 08:38:52 +0000 Message : Merge pull request #1414 from theabro/05-path-update updated path in 05-loop.md to be relative to home directory
Auto-generated via {sandpaper} Source : 57c51cc Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2023-07-23 08:40:08 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 506e621 Branch : main Author : Benson Muite <[email protected]> Time : 2023-07-23 08:38:52 +0000 Message : Merge pull request #1414 from theabro/05-path-update updated path in 05-loop.md to be relative to home directory
Currently, in the "Nelle's Pipeline: Processing Files" section of episodes/05-loop.md (line 597), the text reads
however, the code snippet just below this (line 600) then reads:
cd north-pacific-gyre
This path is incorrect, as if starting from the users home directory this line should read
cd Desktop/shell-lesson-data/north-pacific-gyre