-
Notifications
You must be signed in to change notification settings - Fork 120
Comparing changes
Open a pull request
base repository: swift-server/async-http-client
base: 1.6.2
head repository: swift-server/async-http-client
compare: main
Commits on Oct 13, 2021
-
Don't crash when hitting long backoffs. (#458)
Motivation: If we backoff sufficiently far we can overflow Int64, which will cause us to crash. Modifications: Clamp the backoff value before we convert to Int64. Results: No crashes!
Configuration menu - View commit details
-
Copy full SHA for 1081b0b - Browse repository at this point
Copy the full SHA 1081b0bView commit details -
Configuration menu - View commit details
-
Copy full SHA for c1a60d8 - Browse repository at this point
Copy the full SHA c1a60d8View commit details
Commits on Oct 20, 2021
-
Double quoted cookie values are supported now. (#460)
Motivation: In according to RFC 6265 a cookie value may be placed between double quotes. Modifications: HTTPClient.Cookie ignores now the double quotes at the beginning and the ending of a cookie value. New unit test is added to check it. Result: Quoted cookie values are parsed properly now.
Configuration menu - View commit details
-
Copy full SHA for 1361ecc - Browse repository at this point
Copy the full SHA 1361eccView commit details
Commits on Oct 27, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 4147fd6 - Browse repository at this point
Copy the full SHA 4147fd6View commit details
Commits on Nov 2, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 149b8d2 - Browse repository at this point
Copy the full SHA 149b8d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 60fef53 - Browse repository at this point
Copy the full SHA 60fef53View commit details
Commits on Nov 3, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 18a58bb - Browse repository at this point
Copy the full SHA 18a58bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for b6fb33b - Browse repository at this point
Copy the full SHA b6fb33bView commit details
Commits on Nov 4, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 7d1ed4c - Browse repository at this point
Copy the full SHA 7d1ed4cView commit details
Commits on Nov 9, 2021
-
Configuration menu - View commit details
-
Copy full SHA for d49602f - Browse repository at this point
Copy the full SHA d49602fView commit details
Commits on Nov 10, 2021
-
Configuration menu - View commit details
-
Copy full SHA for cc8e7a6 - Browse repository at this point
Copy the full SHA cc8e7a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 170fd53 - Browse repository at this point
Copy the full SHA 170fd53View commit details
Commits on Nov 11, 2021
-
Handle NIOSSLError.uncleanShutdown correctly (#472)
### Motivation Fixes #238 and #231. ### Changes - Extracted the unclean shutdown test from `HTTPClientTests` into their own file `HTTPClientUncleanSSLConnectionShutdownTests` - Copy and pasted @weissi great explanation from #238 into the test file - Removed property `ignoreUncleanSSLShutdown` everywhere ### Result `ignoreUncleanSSLShutdown` on `HTTPClient.Configuration` is deprecated and ignored. Co-authored-by: Johannes Weiss <johannesweiss@apple.com>
Configuration menu - View commit details
-
Copy full SHA for 7617c35 - Browse repository at this point
Copy the full SHA 7617c35View commit details -
Configuration menu - View commit details
-
Copy full SHA for 38bbe25 - Browse repository at this point
Copy the full SHA 38bbe25View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e44e51 - Browse repository at this point
Copy the full SHA 3e44e51View commit details -
Configuration menu - View commit details
-
Copy full SHA for 164169a - Browse repository at this point
Copy the full SHA 164169aView commit details
Commits on Nov 12, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 68f283c - Browse repository at this point
Copy the full SHA 68f283cView commit details -
[HTTP2] State in README that we support HTTP/2 (#475)
* state in readme that we support HTTP/2 and how to disable it * move HTTP/2 up and use bullet points
Configuration menu - View commit details
-
Copy full SHA for ce01ff2 - Browse repository at this point
Copy the full SHA ce01ff2View commit details
Commits on Nov 17, 2021
-
Only crash in debug mode, if HTTPClient was not shutdown (#478)
### Motivation Generally we want to inform users that they need to shutdown their HTTPClient. Until `1.6.0` we did this with an assert in HTTPClient's deinit. With `1.6.0` this behavior was raised to a precondition. Because of this adopters might suddenly crash in production where they didn't before. ### Changes - This pr reverts the current behavior back to something pre `1.6.0` ### Result - HTTPClient doesn't crash in production anymore.
Configuration menu - View commit details
-
Copy full SHA for ec2e080 - Browse repository at this point
Copy the full SHA ec2e080View commit details
Commits on Nov 18, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 1f3f141 - Browse repository at this point
Copy the full SHA 1f3f141View commit details
Commits on Nov 19, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 2fe3f42 - Browse repository at this point
Copy the full SHA 2fe3f42View commit details
Commits on Nov 22, 2021
-
Configuration menu - View commit details
-
Copy full SHA for b479afe - Browse repository at this point
Copy the full SHA b479afeView commit details -
Two missing
self
s got past soundness. (#489)Co-authored-by: Fabian Fett <fabianfett@apple.com>
Configuration menu - View commit details
-
Copy full SHA for 8713f95 - Browse repository at this point
Copy the full SHA 8713f95View commit details -
Remove a couple of unnecessary imports (#484)
Co-authored-by: Cory Benfield <lukasa@apple.com>
Configuration menu - View commit details
-
Copy full SHA for 8c48625 - Browse repository at this point
Copy the full SHA 8c48625View commit details
Commits on Nov 23, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 0ed00b8 - Browse repository at this point
Copy the full SHA 0ed00b8View commit details -
[Tests] Add some basic IPv6 tests (#483)
Co-authored-by: Cory Benfield <lukasa@apple.com>
Configuration menu - View commit details
-
Copy full SHA for 6426c00 - Browse repository at this point
Copy the full SHA 6426c00View commit details
Commits on Nov 24, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 4fd1150 - Browse repository at this point
Copy the full SHA 4fd1150View commit details
Commits on Nov 25, 2021
-
Update swiftformat to 0.48.8 (#491)
### Motivation Our current swiftformat version does not support async/await. Since we want to add support for async/await we must update swiftformat or disable it. I tried my very best to keep the number of changes as small as possible. I assume we want to stick with the new 0.48.8 for some time. ### Changes - Update swiftformat to 0.48.8 ### Result We can land async/await code.
Configuration menu - View commit details
-
Copy full SHA for e502246 - Browse repository at this point
Copy the full SHA e502246View commit details -
SwiftFormat
--ifdef no-indent
(#494)* SwiftFormat --ifdef no-indent * update `generate_linux_tests.rb` to use new indention rule
Configuration menu - View commit details
-
Copy full SHA for 9eaecbb - Browse repository at this point
Copy the full SHA 9eaecbbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b18e76 - Browse repository at this point
Copy the full SHA 3b18e76View commit details -
Fix flaky tests in
HTTPClientSOCKSTests
(#498)* bind to a port defined by the operating system
Configuration menu - View commit details
-
Copy full SHA for f2bb283 - Browse repository at this point
Copy the full SHA f2bb283View commit details
Commits on Nov 26, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 1119893 - Browse repository at this point
Copy the full SHA 1119893View commit details -
Refactor URL component extraction (#485)
* Refactor URL component extraction * Remove superfluous test message Co-authored-by: Fabian Fett <fabianfett@apple.com> Co-authored-by: David Nadoba <d_nadoba@apple.com>
Configuration menu - View commit details
-
Copy full SHA for f2c2f73 - Browse repository at this point
Copy the full SHA f2c2f73View commit details -
Configuration menu - View commit details
-
Copy full SHA for 83c2625 - Browse repository at this point
Copy the full SHA 83c2625View commit details
Commits on Nov 30, 2021
-
Introduce a
ConnectionTarget
enum (#501)* Add a ConnectionPool.Host enum * Move Host out as a top-level ConnectionTarget type, and use it in Request.
Configuration menu - View commit details
-
Copy full SHA for f1a9187 - Browse repository at this point
Copy the full SHA f1a9187View commit details -
Configuration menu - View commit details
-
Copy full SHA for 591aa44 - Browse repository at this point
Copy the full SHA 591aa44View commit details
Commits on Dec 1, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 70826d0 - Browse repository at this point
Copy the full SHA 70826d0View commit details -
Refactor
deconstructURL
andscheme
parsing (#504)* make `Scheme` a type * introduce new Endpoint type * use endpoint as storage in `HTTPClient.Request` * fix merge conflicts * rename Endpoint to DeconstructedURL * swift-format * make `DeconstructedURL` properties `var`'s * move scheme into global namespace - rename `useTLS` to `usesTLS` where posible without breaking public API - only import Foundation.URL * fix review comments
Configuration menu - View commit details
-
Copy full SHA for 99bd384 - Browse repository at this point
Copy the full SHA 99bd384View commit details
Commits on Dec 2, 2021
-
* HTTPClientRequest * move into single file * fix review comments * remove overload
Configuration menu - View commit details
-
Copy full SHA for a956e7b - Browse repository at this point
Copy the full SHA a956e7bView commit details
Commits on Dec 3, 2021
-
Add HTTPClientReuqest.Prepared (#511)
* add HTTPClientReuqest.Prepared * make `prepared()` an init of `Prepared` * make all stored properties of `Prepared` `var`s
Configuration menu - View commit details
-
Copy full SHA for 5ce7377 - Browse repository at this point
Copy the full SHA 5ce7377View commit details -
Improve test utils for running request (#512)
### Motivation To land support for async/await, we need test utilities. We already have a `MockRequestExecutor`. Let's improve this to better handle on and off `EventLoop` request processing. ### Changes - Move `MockRequestExecutor` into its own file - Add blocking APIs to `MockRequestExecutor` when called from another thread
Configuration menu - View commit details
-
Copy full SHA for 65d97ff - Browse repository at this point
Copy the full SHA 65d97ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 474b23d - Browse repository at this point
Copy the full SHA 474b23dView commit details
Commits on Dec 6, 2021
-
MockRequestExecutor runRequest (#517)
### Motivation Our actual HTTPRequestExecutors send out an HTTPRequest as soon as they see it and they call `willExecuteRequest` and `requestHeadSent` in very fast succession on the `HTTPExecutableRequest`. We should have the same behavior in tests. ### Changes - Call `requestHeadSent` from `MockRequestExecutor.runRequest` - Tests that use `MockRequestExecutor` call `runRequest` on it first ### Result Cleaner, more life like tests
Configuration menu - View commit details
-
Copy full SHA for 93de326 - Browse repository at this point
Copy the full SHA 93de326View commit details -
* test `HTTPClientRequest.Prepared` and `HTTPClientRequest.Body` * add scheme and headers tests * fix tests
Configuration menu - View commit details
-
Copy full SHA for cc17c9c - Browse repository at this point
Copy the full SHA cc17c9cView commit details -
This PR adds an AsyncWriter that we can be used to test our new async upload streaming API. Co-authored-by: George Barnett <gbarnett@apple.com>
Configuration menu - View commit details
-
Copy full SHA for a79206d - Browse repository at this point
Copy the full SHA a79206dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 29d194f - Browse repository at this point
Copy the full SHA 29d194fView commit details
Commits on Dec 7, 2021
-
Cleanup MockRequestExecutor (#521)
In async tests, we need to wait for events that happen on the async executor. We can use ConditionLocks to wait for async events to happen while using a synchronous invocation model in the tests. In this pr we restructure `MockRequestExecutor` to use `ConditionLock`s where appropiate.
Configuration menu - View commit details
-
Copy full SHA for 3d7c42e - Browse repository at this point
Copy the full SHA 3d7c42eView commit details
Commits on Dec 8, 2021
-
Refactor redirect logic to be reusable for async/await (#522)
* refactor RedirectHandler - `redirectState` is no longer a property of `HTTPClient.Request`. RedirectHandler now stores this state directly and therefore no longer optional. - we no longer count the number of allowed redirects down. Instead the number of redirects is dervied from `self.visited.count` and we compare it to the maxRedirect to check if we git the limit. * `HTTPClient.Configuration.RedirectConfiguration.Configuration` is now called `HTTPClient.Configuration.RedirectConfiguration.Mode` only two `Configuration`s left in the type name * add redirect logger test
Configuration menu - View commit details
-
Copy full SHA for c4feafd - Browse repository at this point
Copy the full SHA c4feafdView commit details
Commits on Dec 9, 2021
-
This introduces an async Transaction object. The object is the translation layer between the user facing async API and the NIO channel handler.
Configuration menu - View commit details
-
Copy full SHA for 24b0a14 - Browse repository at this point
Copy the full SHA 24b0a14View commit details
Commits on Dec 14, 2021
-
add missing @available anotations (#525)
Otherwise it fails to compile with Xcode 13.1. Xcode 13.2 seems fine without but this is probably a regression in the swift compiler because the @available anotations are actally needed.
Configuration menu - View commit details
-
Copy full SHA for 18c7266 - Browse repository at this point
Copy the full SHA 18c7266View commit details
There are no files selected for viewing
This file was deleted.