Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable MemberImportVisibility check on all targets #794

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

rnro
Copy link
Collaborator

@rnro rnro commented Dec 9, 2024

Enable MemberImportVisibility check on all targets. Use a standard string header and footer to bracket the new block for ease of updating in the future with scripts.

@rnro rnro added the semver/none No version bump required. label Dec 9, 2024
@rnro rnro force-pushed the enable_MemberImportVisibility_check branch from a6d80c9 to 30f50cf Compare December 10, 2024 10:30
@rnro rnro changed the title Enable MemberImportVisibility check on 6.0+ pipelines Enable MemberImportVisibility check on all targets Dec 10, 2024
@rnro rnro force-pushed the enable_MemberImportVisibility_check branch 2 times, most recently from e582692 to 195fd09 Compare December 10, 2024 10:43
@rnro rnro force-pushed the enable_MemberImportVisibility_check branch 4 times, most recently from 2a8e14d to d3af950 Compare December 11, 2024 11:24
@rnro rnro force-pushed the enable_MemberImportVisibility_check branch from d3af950 to dcdae00 Compare December 11, 2024 11:56
@rnro rnro added 🔨 semver/patch No public API change. and removed semver/none No version bump required. labels Dec 11, 2024
@rnro rnro enabled auto-merge (squash) December 11, 2024 15:26
@rnro rnro merged commit dbd5c86 into swift-server:main Dec 13, 2024
24 checks passed
tshortli added a commit to tshortli/async-http-client that referenced this pull request Jan 29, 2025
In swift-server#794, the new Swift
compiler feature `MemberImportVisibility` was adopted. However, CI for this
project does not test building the package with the nightly compiler on macOS,
so it was missed that the project no longer builds on macOS due to a missing
import.
tshortli added a commit to tshortli/async-http-client that referenced this pull request Jan 29, 2025
In swift-server#794, the new Swift
compiler feature `MemberImportVisibility` was adopted. However, CI for this
project does not test building the package with the nightly compiler on macOS,
so it was missed that the project no longer builds on macOS with the nightly
toolchain due to a missing import.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants