Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make GroupVersionResource conform to Codable #9

Merged
merged 1 commit into from
Sep 9, 2023
Merged

Make GroupVersionResource conform to Codable #9

merged 1 commit into from
Sep 9, 2023

Conversation

ewilken
Copy link
Contributor

@ewilken ewilken commented Sep 8, 2023

I came across this coming handy when passing custom resources around to open them in new windows.

@ewilken ewilken marked this pull request as ready for review September 8, 2023 14:39
@iabudiab
Copy link
Member

iabudiab commented Sep 9, 2023

@ewilken Yes, absolutely. Nice catch. This should've been Codable since it was first introduced

@iabudiab iabudiab merged commit 8ddd7d3 into swiftkube:main Sep 9, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewilken @iabudiab