Do not block initialization of the build server when build server is unresponsive in returning the list of test files #1999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead of `BuiltInBuildSystem` This gives the injected build system more flexibility by being able to respond to all BSP messages instead of only those methods defined in `BuiltInBuildSystem`.
…element in a collection This is simpler to reason about than creating a `TaskGroup`.
…unresponsive in returning the list of test files We were blocking the initialization response on `self.buildSystemManager.testFiles`, which requires the list of test files to be determined. Make that operation asynchronous so that a slow build server can’t take down all of SourceKit-LSP.
hamishknight
approved these changes
Feb 25, 2025
bnbarham
reviewed
Feb 25, 2025
| await body(element) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Doesn't this need either a wait on each of the tasks or a taskGroup.waitForAll()?
There was a problem hiding this comment.
No, from the documentation of withTaskGroup. I only learned this now, which is why I had waitForAll in older implementations.
A group waits for all of its child tasks to complete or be canceled before it returns.
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1996
We were blocking the initialization response on
self.buildSystemManager.testFiles, which requires the list of test files to be determined. Make that operation asynchronous so that a slow build server can’t take down all of SourceKit-LSP.