10204: ngx-select Caret and Clear Size and Alignment Fix #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created a (flex) wrapper around the select input and the control buttons (clear, open) to have more control over the vertical alignment of all the inner content.
✅ Deploy Preview for ngx-ui ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
bmangaman
changed the title
Hypercubed
approved these changes
Aug 12, 2022
bmangaman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed the issue of inconsistent sizing and vertical alignment of the clear (x) and caret (v) by wrapping both the input and the input controls in a flex box and using flex properties instead of absolute alignment.
Fixes ngx-select caret scales inconsistently #583
Checklist
/projects/swimlane/ngx-ui/CHANGELOG.mdunder HEAD (Unreleased)*required