Skip to content

Commit

Permalink
fix: move interfaces to contracts and use Elastic client in service p…
Browse files Browse the repository at this point in the history
…rovider instead of our own
  • Loading branch information
tommie1001 committed Jul 5, 2023
1 parent 2d94757 commit 929a638
Show file tree
Hide file tree
Showing 13 changed files with 20 additions and 19 deletions.
6 changes: 3 additions & 3 deletions config/elasticsearch.php
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<?php

return [
'host' => env('ELASTIC_HOST', 'localhost:9200'),
'index' => env('ELASTIC_INDEX', 'index'),
'enabled' => env('ELASTIC_ENABLED', false),
'host' => env('ELASTICSEARCH_HOST', 'localhost:9200'),
'index' => env('ELASTICSEARCH_INDEX', 'index'),
'enabled' => env('ELASTICSEARCH_ENABLED', false),
'models' => [
// define your model classes here that needs to be indexed
],
Expand Down
2 changes: 1 addition & 1 deletion src/Client.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
use Elastic\Elasticsearch\Client as ElasticsearchClient;
use Elastic\Elasticsearch\Response\Elasticsearch;
use Illuminate\Support\Collection;
use Swis\Laravel\Elasticsearch\Interfaces\SearchResultInterface;
use Swis\Laravel\Elasticsearch\Contracts\SearchResultInterface;

class Client
{
Expand Down
8 changes: 4 additions & 4 deletions src/Commands/ElasticsearchCreateIndex.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,18 +6,18 @@

use Elastic\Elasticsearch\Client;
use Illuminate\Console\Command;
use Swis\Laravel\Elasticsearch\Interfaces\IndexMappingBuilderInterface;
use Swis\Laravel\Elasticsearch\Contracts\IndexMappingBuilderInterface;

class ElasticsearchCreateIndex extends Command
{
protected $signature = 'elasticsearch:create-index {--index= : index that needs to be created (index from config is used if option is omitted)}';

protected $description = 'Creates index in elasticsearch';

public function getConfigBuilderClass(): array
public function getIndexMapping(): array
{
return app()->bound(IndexMappingBuilderInterface::class) ?
app(IndexMappingBuilderInterface::class)->buildIndexMappingUsing() :
app(IndexMappingBuilderInterface::class)->indexMapping() :
config('elasticsearch.index_mapping');
}

Expand All @@ -27,7 +27,7 @@ public function handle(Client $client): int

$client->indices()->create([
'index' => $index,
'body' => $this->getConfigBuilderClass(),
'body' => $this->getIndexMapping(),
]);

$this->info(sprintf('Index "%s" created', $index));
Expand Down
2 changes: 1 addition & 1 deletion src/Commands/ElasticsearchRefreshIndex.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

use Illuminate\Console\Command;
use Illuminate\Support\Collection;
use Swis\Laravel\Elasticsearch\Interfaces\IndexableInterface;
use Swis\Laravel\Elasticsearch\Contracts\IndexableInterface;

class ElasticsearchRefreshIndex extends Command
{
Expand Down
4 changes: 2 additions & 2 deletions src/Concerns/SyncsWithIndex.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@

use Illuminate\Database\Eloquent\Model;
use Illuminate\Support\Collection;
use Swis\Laravel\Elasticsearch\Interfaces\DocumentInterface;
use Swis\Laravel\Elasticsearch\Interfaces\IndexableInterface;
use Swis\Laravel\Elasticsearch\Contracts\DocumentInterface;
use Swis\Laravel\Elasticsearch\Contracts\IndexableInterface;
use Swis\Laravel\Elasticsearch\Jobs\DeleteDocument;
use Swis\Laravel\Elasticsearch\Jobs\IndexDocument;

Expand Down
2 changes: 1 addition & 1 deletion src/Document.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
namespace Swis\Laravel\Elasticsearch;

use Illuminate\Support\Carbon;
use Swis\Laravel\Elasticsearch\Interfaces\DocumentInterface;
use Swis\Laravel\Elasticsearch\Contracts\DocumentInterface;

class Document implements DocumentInterface
{
Expand Down
2 changes: 1 addition & 1 deletion src/Interfaces/DocumentInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

declare(strict_types=1);

namespace Swis\Laravel\Elasticsearch\Interfaces;
namespace Swis\Laravel\Elasticsearch\Contracts;

use Illuminate\Support\Carbon;

Expand Down
4 changes: 2 additions & 2 deletions src/Interfaces/IndexMappingBuilderInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@

declare(strict_types=1);

namespace Swis\Laravel\Elasticsearch\Interfaces;
namespace Swis\Laravel\Elasticsearch\Contracts;

interface IndexMappingBuilderInterface
{
public function buildIndexMappingUsing(): array;
public function indexMapping(): array;
}
2 changes: 1 addition & 1 deletion src/Interfaces/IndexableInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

declare(strict_types=1);

namespace Swis\Laravel\Elasticsearch\Interfaces;
namespace Swis\Laravel\Elasticsearch\Contracts;

use Illuminate\Support\Collection;
use Swis\Laravel\Elasticsearch\Document;
Expand Down
2 changes: 1 addition & 1 deletion src/Interfaces/SearchResultInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

declare(strict_types=1);

namespace Swis\Laravel\Elasticsearch\Interfaces;
namespace Swis\Laravel\Elasticsearch\Contracts;

interface SearchResultInterface
{
Expand Down
2 changes: 1 addition & 1 deletion src/Jobs/IndexDocument.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
use Illuminate\Foundation\Bus\Dispatchable;
use Illuminate\Queue\InteractsWithQueue;
use Illuminate\Queue\SerializesModels;
use Swis\Laravel\Elasticsearch\Interfaces\IndexableInterface;
use Swis\Laravel\Elasticsearch\Contracts\IndexableInterface;

class IndexDocument implements ShouldQueue
{
Expand Down
1 change: 1 addition & 0 deletions src/LaravelElasticServiceProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

namespace Swis\Laravel\Elasticsearch;

use Elastic\Elasticsearch\Client;
use Elastic\Elasticsearch\ClientBuilder;
use Spatie\LaravelPackageTools\Commands\InstallCommand;
use Spatie\LaravelPackageTools\Package;
Expand Down
2 changes: 1 addition & 1 deletion src/SearchResult.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

use Illuminate\Contracts\Support\Arrayable;
use Illuminate\Support\Carbon;
use Swis\Laravel\Elasticsearch\Interfaces\SearchResultInterface;
use Swis\Laravel\Elasticsearch\Contracts\SearchResultInterface;

/** @phpstan-ignore-next-line */
class SearchResult implements Arrayable, SearchResultInterface
Expand Down

0 comments on commit 929a638

Please sign in to comment.