Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reset release v7 workflow and set tag "latest-v7" to all publishable package.json files #3525

Open
wants to merge 3 commits into
base: release/v7
Choose a base branch
from

Conversation

oliverschuerch
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Sep 10, 2024

⚠️ No Changeset found

Latest commit: 46d4ee4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Sep 10, 2024

Related Previews

Copy link

sonarcloud bot commented Sep 10, 2024

Copy link
Member

@gfellerph gfellerph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oliverschuerch, the styles v7 are currently published under 7.4.2. If we release v7 with a tag, say @swisspost/[email protected]@latest-v7. Will somebody installing with npm i @swisspost/design-system-styles@7 get 7.4.2 or 7.4.3@latest-v7?

What happens on npm install when the styles are installed as { "@swisspost/design-system-styles": "^7.4.2" }? Do they get 7.4.3@latest-v7?

Maybe we should do some testing before implementing this.

@oliverschuerch oliverschuerch changed the title chore: reset release v7 workflow and set tag "latest-v7" to all publishable package.json files in the monorepo chore: reset release v7 workflow and set tag "latest-v7" to all publishable package.json files Sep 11, 2024
@oliverschuerch oliverschuerch requested review from a team and alizedebray and removed request for a team September 11, 2024 10:54
@oliverschuerch
Copy link
Contributor Author

@oliverschuerch, the styles v7 are currently published under 7.4.2. If we release v7 with a tag, say @swisspost/[email protected]@latest-v7. Will somebody installing with npm i @swisspost/design-system-styles@7 get 7.4.2 or 7.4.3@latest-v7?

What happens on npm install when the styles are installed as { "@swisspost/design-system-styles": "^7.4.2" }? Do they get 7.4.3@latest-v7?

Maybe we should do some testing before implementing this.

As far as I know:

  • A taged version can always be installed without the tag, by just using a semver (like @7, @7.4, etc.).
  • A tag set on a specific semver is always optional to use.
  • A tag is unic, which means, you will never end up having to semvers using the same tag.

So:

  • If you run npm i package-name@7, you will always get the latest version with the major version 7.
  • You could also use npm i package-name@latest-v7, but no one will probably ever do that.
  • If you run npm i package-name@latest you will always get the version which contains this tag.

I don't think this should be a problem. But we can for sure test it ;)

@gfellerph
Copy link
Member

@oliverschuerch confirmed the behavior you described with an internal test. Tagged packages installed with in-the-middle-versions will install according to their version disregarding the tag and will not override the higher versioned latest tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants