feat: foundations typography legend #3614
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
🦋 Changeset detectedLatest commit: 81832e4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 17 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gfellerph
requested changes
Oct 3, 2024
packages/documentation/src/stories/elements/legend/legend.stories.ts
Outdated
Show resolved
Hide resolved
Comment on lines
145
to
157
|
|
||
| fieldset, | ||
| legend { | ||
| padding: 0; | ||
| } | ||
|
|
||
| fieldset { | ||
| border: 0; | ||
| } | ||
|
|
||
| legend { | ||
| width: 100%; | ||
| } |
There was a problem hiding this comment.
This would belong into the element styles.
There was a problem hiding this comment.
The width style is moved to element styles.
There was a problem hiding this comment.
Should we name this file fieldset-legend.scss?
Co-authored-by: Philipp Gfeller <[email protected]>
…ies.ts Co-authored-by: Philipp Gfeller <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.