Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDCISA-13110] Support Redis 6.x authentication method #133

Merged
merged 4 commits into from
Aug 29, 2023

Conversation

thwint
Copy link

@thwint thwint commented Aug 25, 2023

  • added username and password authentication

Made redisques aware of new ACL authentication method introduced with Redis 6.

- added username and password authentication
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Patch coverage: 83.33% and project coverage change: +0.15% 🎉

Comparison is base (9358497) 64.04% compared to head (d085642) 64.20%.
Report is 8 commits behind head on develop.

❗ Current head d085642 differs from pull request most recent head 62d6205. Consider uploading reports for the commit 62d6205 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #133      +/-   ##
=============================================
+ Coverage      64.04%   64.20%   +0.15%     
- Complexity       331      336       +5     
=============================================
  Files             25       25              
  Lines           2161     2176      +15     
  Branches         264      265       +1     
=============================================
+ Hits            1384     1397      +13     
- Misses           637      638       +1     
- Partials         140      141       +1     
Files Changed Coverage Δ
...rg/swisspush/reststorage/DefaultRedisProvider.java 75.60% <66.66%> (-0.87%) ⬇️
...wisspush/reststorage/util/ModuleConfiguration.java 81.10% <100.00%> (+1.27%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thwint thwint changed the title [SDCISA-13110] K8s: Make Houston runnable [SDCISA-13110] Support Redis 6.x authentication method Aug 28, 2023
- separated redisAuth and redisPassword
- added new module config fields to test
- added new module config fields to test
@thwint thwint merged commit 3e24ecb into swisspost:develop Aug 29, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants