Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#124 Added reconnect to DefaultRedisProvider #137

Merged

Conversation

mcweba
Copy link
Collaborator

@mcweba mcweba commented Sep 5, 2023

These changes have already been implemented in PR 125 and PR 127. They were replaced with just the Interface. Now the code was added again.

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch coverage: 63.55% and project coverage change: -0.61% ⚠️

Comparison is base (3e24ecb) 64.20% compared to head (fd0925a) 63.59%.
Report is 20 commits behind head on develop.

❗ Current head fd0925a differs from pull request most recent head ace6fbe. Consider uploading reports for the commit ace6fbe to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #137      +/-   ##
=============================================
- Coverage      64.20%   63.59%   -0.61%     
- Complexity       336      382      +46     
=============================================
  Files             25       32       +7     
  Lines           2176     2409     +233     
  Branches         265      291      +26     
=============================================
+ Hits            1397     1532     +135     
- Misses           638      721      +83     
- Partials         141      156      +15     
Files Changed Coverage Δ
...va/org/swisspush/reststorage/MimeTypeResolver.java 81.48% <ø> (ø)
...reststorage/ModuleConfigurationAuthentication.java 64.28% <ø> (ø)
.../swisspush/reststorage/RedisRestStorageRunner.java 0.00% <0.00%> (ø)
.../org/swisspush/reststorage/redis/RedisStorage.java 69.11% <ø> (ø)
.../swisspush/reststorage/util/FailedAsyncResult.java 0.00% <0.00%> (ø)
.../java/org/swisspush/reststorage/util/LockMode.java 100.00% <ø> (ø)
...va/org/swisspush/reststorage/redis/RedisUtils.java 36.36% <36.36%> (ø)
...rg/swisspush/reststorage/DefaultRedisProvider.java 56.41% <43.75%> (-19.20%) ⬇️
...swisspush/reststorage/lock/lua/LuaScriptState.java 67.27% <67.27%> (ø)
.../reststorage/lock/lua/ReleaseLockRedisCommand.java 67.85% <67.85%> (ø)
... and 6 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcweba mcweba merged commit 045623d into develop Sep 6, 2023
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant